Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044803Openbravo ERPA. Platformpublic2020-08-12 16:592020-10-15 12:51
Reportershuehner 
Assigned Toplatform 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR21Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044803: Support for old-style callout (HttpServletBased and not SimpleCallout) should be removed (for generated-Windows, ad_callout)
DescriptionAll modern callouts are based on SimpleCallout after a mass-refactor in issue 36067 (17Q4 release).
Even before then new callouts written were using SimpleCallout for several years.

To simplify the code in FormInitializionComponent the support for the old system should be removed.

Also this support for old callouts is one of the two only cases where backend code is needing a JS execution engine which will require extra work to continue to be usable with JDK>=15 (see issue 43903)

This issue specifically is about code registered in ad_callout and used FormInitializationComtent (as part of generated standard windows)
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on design defect 0044795 new Triage Omni OMS Tracking issue to refactor remaining old callouts to extend SimpleCallout 
related to design defect 0043903 closed cberner Openbravo fails to compile with JDK15 because of removal of Nashorn JS engine 
blocks design defect 0044811 new Triage Platform Base Support for old-style callout (HttpServletBased and not SimpleCallout) should be removed totally even when used in manual HTML 
causes defect 0045231 closed cberner API Change: Removed HttpServletCalloutInformationProvider class 
Not all the children of this issue are yet resolved or closed.
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-08-12 16:59shuehnerNew Issue
2020-08-12 16:59shuehnerAssigned To => platform
2020-08-12 16:59shuehnerModules => Core
2020-08-12 16:59shuehnerTriggers an Emergency Pack => No
2020-08-12 16:59shuehnerRelationship addeddepends on 0044795
2020-08-12 16:59shuehnerRelationship addedrelated to 0043903
2020-08-13 15:37shuehnerSummarySupport for old-style callout (HttpServletBased and not SimpleCallout) should be removed => Support for old-style callout (HttpServletBased and not SimpleCallout) should be removed (for generated-Windows, ad_callout)
2020-08-13 15:37shuehnerDescription Updatedbug_revision_view_page.php?rev_id=21491#r21491
2020-08-13 15:47shuehnerIssue cloned0044811
2020-08-13 15:47shuehnerRelationship addedblocks 0044811
2020-09-14 18:01hgbotNote Added: 0123030
2020-09-14 18:08hgbotNote Added: 0123033
2020-09-14 18:08hgbotNote Added: 0123034
2020-10-15 12:35cbernerRelationship addedcauses 0045231
2020-10-15 12:51hgbotResolutionopen => fixed
2020-10-15 12:51hgbotStatusnew => closed
2020-10-15 12:51hgbotNote Added: 0123712
2020-10-15 12:51hgbotFixed in Version => PR21Q1
2020-10-15 12:51hgbotNote Added: 0123713
2020-10-15 12:51hgbotNote Added: 0123714

Notes
(0123030)
hgbot   
2020-09-14 18:01   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/163 [^]
(0123033)
hgbot   
2020-09-14 18:08   
Merge request closed: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/163 [^]
(0123034)
hgbot   
2020-09-14 18:08   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/164 [^]
(0123712)
hgbot   
2020-10-15 12:51   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/164 [^]
(0123713)
hgbot   
2020-10-15 12:51   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: f41ef039ca5f7a424f8567a99e5855f3d780e8a6
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2020-10-15T11:30:18+02:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/f41ef039ca5f7a424f8567a99e5855f3d780e8a6 [^]

Fixes ISSUE-44803: Remove support for old-style (HttpServlet based) callouts

All modern callouts are based on SimpleCallout and this should always be
used as a base. Support for old callouts based on HttpServlet is
removed from ad_callout and FormInitializationContent.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/ViewComponent.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-view-manager.js
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelServlet.java
M src-test/src/org/openbravo/test/AllAntTaskTests.java
M src/org/openbravo/erpCommon/ad_callouts/CalloutConstants.java
R src-test/src/org/openbravo/test/system/OldCallouts.java
R src/org/openbravo/erpCommon/ad_callouts/HttpServletCalloutInformationProvider.java
---
(0123714)
hgbot   
2020-10-15 12:51   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 7dab7882d5d9e700a6a59a0c30f65c0a90f12b07
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2020-10-15T11:30:18+02:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/7dab7882d5d9e700a6a59a0c30f65c0a90f12b07 [^]

Related to ISSUE-44803: Fail on View generation when callout not implemented

When a callout class implementation is not found or there's no callout
implementation in the corresponding table, View generation will fail
with an exception. Previously it only failed with an exception on
Callouts that used old callout type based on HttpServlet.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/ViewComponent.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
---