Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044795Openbravo ERPZ. Otherspublic2020-08-12 16:052020-08-13 15:58
Reportershuehner 
Assigned ToTriage Omni OMS 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusnewResolutionopen 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044795: Tracking issue to refactor remaining old callouts to extend SimpleCallout
DescriptionIn 17Q4 release (nearly) all old callouts have been refactored to extend SimpleCallout in issue 36067 (and related issues).

Main benefits were to avoid relevant overhead on processing of old style callouts which is avoided with Simplecallouts (not http call simulation, no html, java script engine needed to extract values inside FIC).

Hover not all callouts in modules have been converted which is blocking eventual removal of support for old-style callouts.

This issue serves to track the individual remaining modules which require conversion.
Steps To ReproduceSearch for ad_callout entries where the java class implementing them does NOT extend SimpleCallout

Example command:
grep -Ir 'var respuesta' .

Attachment detect-callouts.diff in issue '36067' also has junit test do detect them.
Proposed SolutionRefactor remaining callouts to extend Simplecallout as has been done for most in issue 36067 already.
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0036067 closed markmm82 Openbravo ERP old callouts should be refactored to implement SimpleCallout 
related to design defect 0044811 new Triage Platform Base Openbravo ERP Support for old-style callout (HttpServletBased and not SimpleCallout) should be removed totally even when used in manual HTML 
depends on defect 0044797 closed Mery Anelo Modules OBIRB_SE_BusinessPartnerTaxId is an old-style callout and should be refactored to use SimpleCallout 
depends on defect 0044798 closed Mery Anelo Modules INTR_SE_IntrastatLauncher is an old-style callout and should be refactored to use SimpleCallout 
depends on defect 0044799 closed inigo_lerga Modules IDL_Check_DataType is an old-style callout and should be refactored to use SimpleCallout 
depends on defect 0044801 closed Mery Anelo Localization Pack: Spain SE_CIFNIF_Validator is an old-style callout and should be refactored to use SimpleCallout 
depends on defect 0044802 closed Mery Anelo Localization Pack: Spain org.openbravo.module.finactvalidator.es has 2 old-style callouts not yet refactored to extend SimpleCallout 
depends on defect 0044812 closed inigo_lerga Openbravo ERP SL_MInOutTraceReports callout is old-style callout (not SimpleCallout) but also used in manual HTML code 
depends on defect 0044813 closed inigo_lerga Openbravo ERP SL_CreateLines_Conversion_UOM callout is old-style callout (not SimpleCallout) but also used in manual HTML code 
blocks design defect 0044803 closed platform Openbravo ERP Support for old-style callout (HttpServletBased and not SimpleCallout) should be removed (for generated-Windows, ad_callout) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-08-12 16:05shuehnerNew Issue
2020-08-12 16:05shuehnerAssigned To => Triage Finance
2020-08-12 16:05shuehnerModules => Core
2020-08-12 16:05shuehnerTriggers an Emergency Pack => No
2020-08-12 16:06shuehnerNote Added: 0122015
2020-08-12 16:41shuehnerRelationship addeddepends on 0044797
2020-08-12 16:43shuehnerRelationship addeddepends on 0044798
2020-08-12 16:45shuehnerRelationship addeddepends on 0044799
2020-08-12 16:46shuehnerRelationship addeddepends on 0044800
2020-08-12 16:48shuehnerRelationship addeddepends on 0044801
2020-08-12 16:54shuehnerRelationship addeddepends on 0044802
2020-08-12 16:54shuehnerRelationship addedrelated to 0036067
2020-08-12 16:59shuehnerRelationship addedblocks 0044803
2020-08-13 15:48shuehnerRelationship addedrelated to 0044811
2020-08-13 15:49shuehnerRelationship deleteddepends on 0044800
2020-08-13 15:56shuehnerRelationship addeddepends on 0044812
2020-08-13 15:58shuehnerRelationship addeddepends on 0044813

Notes
(0122015)
shuehner   
2020-08-12 16:06   
Existing wiki documentation for callouts only talks about the 'new' System with SimpleCallouts for many years:

http://wiki.openbravo.com/wiki/How_to_create_a_Callout [^]
http://wiki.openbravo.com/wiki/How_to_create_a_callout_that_extends_from_another_callout [^]