Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044785ModulesFrench Fiscalpublic2020-08-11 13:342020-09-08 14:34
Reportervmromanos 
Assigned Tovmromanos 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customer
Regression introduced in release
Summary0044785: Add default flag for touchpoint blockchain enable
DescriptionWe have recently changed the blockchain enabled flag at touchpoint level from true to false (see 0044748). The purpose is to avoid enabling it by default in new terminals. However this forces the user to remember to initialize the blockchain for the new terminal.

Minor improvement: To try to make this process automatic. We will add a new flag at legal entity level to specify whether the new terminals should have the blockchain flag enabled by default. This will allow to automatically set the flag to true for french terminals, and to false for other countries.
Steps To ReproduceCreate a new touchpoint
Verify the blockchain initialized flag is set to N
This forces the user to manually run the Initialize blockchain process for this terminal.


Ideally we should create a global configuration to automatically set this flag to Yes for terminals available in selected organizations.
Proposed SolutionNew flag "Initialize Blockchain in New POS Touchpoints" at Organization window, only shown for Legal Entities.

New trigger in Touchpoint table to set the Blockchain Initialized flag value based on the related legal entity "Initialize Blockchain in New POS Touchpoints" flag. The logic will only work for POS type terminals, other kind of terminals will be set always to Initialize Blockchain to false.
Additional Information
TagsNo tags attached.
Relationships
causes defect 0045015 closed vmromanos Openbravo Localizations Copy Store not working with Frenc Certification 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-08-11 13:34vmromanosNew Issue
2020-08-11 13:34vmromanosAssigned To => Triage Finance
2020-08-11 13:41vmromanosStatusnew => scheduled
2020-08-11 13:41vmromanosAssigned ToTriage Finance => vmromanos
2020-08-12 10:58hgbotNote Added: 0122002
2020-08-12 11:06vmromanosNote Added: 0122003
2020-08-17 08:26hgbotNote Added: 0122092
2020-08-17 08:26hgbotResolutionopen => fixed
2020-08-17 08:26hgbotStatusscheduled => closed
2020-08-17 08:26hgbotNote Added: 0122093
2020-08-21 19:32aferrazIssue cloned0044870
2020-09-08 14:34hgbotNote Added: 0122796
2020-09-10 10:37vmromanosRelationship addedcauses 0045015

Notes
(0122002)
hgbot   
2020-08-12 10:58   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev/-/merge_requests/6 [^]
(0122003)
vmromanos   
2020-08-12 11:06   
Test plan:

Login in Openbravo ERP.
Change role to White Valley Group Admin
Go to Organization window.
Open the "White Valley Spain S.A" record in form view. Verify there is a new "French Fiscal" field group with a new "Initialize Blockchain in New POS Touchpoints" flag. It's set to false. Select it and save.
Go back to grid and select *. Verify the "French Fiscal" field group is hidden.
Go back to grid and select AMS (Aneto Mountain Store). Verify the "French Fiscal" field group is hidden.

Go to Channel - Touchpoint window.
Create a new record. Select Aneto Mountain Store, fill mandatory fields. Save it. Verify Blockchain Initialized flag in status bar is set to Yes.
Create a new record. Select Magento store, fill mandatory fields. Save it. Verify Blockchain Initialized flag in status bar is set to No (as the touchpoint type is not a POS).
Create a new record. Select Central Mountains Store, fill mandatory fields. Save it. Verify Blockchain Initialized flag in status bar is set to No.
(0122092)
hgbot   
2020-08-17 08:26   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev/-/merge_requests/6 [^]
(0122093)
hgbot   
2020-08-17 08:26   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev [^]
Changeset: abf01bd806a2caeb8c55760550e18709866de167
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 2020-08-17T06:21:08+00:00
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev/-/commit/abf01bd806a2caeb8c55760550e18709866de167 [^]

Fixed ISSUE-44785: New flag at Organization level to default terminal blockchain

The new flag "Initialize Blockchain in New POS Touchpoints" is available for legal entities only at Organization window. The display logic works using an auxiliary input.

Added a field group to embed this flag to follow the convention in the Organization window.

Added trigger to initialize Touchpoint blockchain. The trigger will work on insert event and, in case of a POS Touchpoint, it will automatically set the Initialize Blockchain flag equals to the legal entity's default configuration.

---
A src-db/database/model/modifiedTables/AD_ORG.xml
A src-db/database/sourcedata/AD_AUXILIARINPUT.xml
A src-db/database/sourcedata/AD_FIELDGROUP.xml
M src-db/database/model/triggers/OBCFR_OBPOS_APPLICATIONS_TRG.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
---
(0122796)
hgbot   
2020-09-08 14:34   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.certification.france [^]
Changeset: f5224785d5d69309ea9695694920a91112b45905
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 2020-09-08T14:04:02+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.certification.france/-/commit/f5224785d5d69309ea9695694920a91112b45905 [^]

Synchronized from development repo (rev 9f2178b)

Synchronized src-db
Updated jar
Synchronized JS files
Updated module hash
Updated module version to 1.0.110

-- Included changesets:
f2f343c Updated minor version to 1.0.110
34d5f92 Fixes ISSUE-44884: Reduce hashed json scope including only main ticket properties
7cf2a16 Updated module hash
68446f1 Related to ISSUE-44843: Fix jslint errors
b582563 Related to ISSUE-44843: Implement the TicketList model in the new state engine
4268332 [ticket-list] delete unneeded validations
ca30265 Updated module hash
abf01bd Fixed ISSUE-44785: New flag at Organization level to default terminal blockchain
3246341 Fixed BUG-44783: Log client's ID in Security Background
2106315 fixes BUG-44542:APplied new HQL style
3d2c5e4 Update module hash
daf6af4 Fixes ISSUE-44749: Run TicketInitialValidation only if terminal has blockchain initialized
cef7608 Fixes ISSUE-44748: Change isBlockchained column default value to false
42c9637 Fixes ISSUE-44669: Avoid client/org check when setting admin mode

---
A src-db/database/model/modifiedTables/AD_ORG.xml
A src-db/database/sourcedata/AD_AUXILIARINPUT.xml
A src-db/database/sourcedata/AD_FIELDGROUP.xml
M lib/runtime/org.openbravo.certification.france-1.0.jar
M src-db/database/model/triggers/OBCFR_OBPOS_APPLICATIONS_TRG.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MODULE.xml
M web/org.openbravo.certification.france/js/ticket/preOrderSaveFinishCancelLayawayHook.js
M web/org.openbravo.certification.france/js/ticket/preSyncReceiptHook.js
---