Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044645Openbravo ERP07. Sales managementpublic2020-07-21 11:532020-07-23 12:04
Reporteradrianromero 
Assigned Toadrianromero 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR20Q4 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044645: API Change: Changed signature of method getProductIds() in class ImportProductInDiscount
DescriptionThe method signature has changed from:

protected List<String> getProductIds(String productKey) {

To

protected List<String> getProductIds(String clientId, String orgId, String productKey) {

The reasons is that now product key is not unique globally is unique only in the context of the same client and same legal entity. So client and org must be passed to the method
Steps To ReproduceIn description.
Proposed Solution
Additional Information
TagsApproved
Relationships
caused by defect 0044579 closed ranjith_qualiantech_com Button to upload products: Window Discount and Promotions 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-07-21 11:53adrianromeroNew Issue
2020-07-21 11:53adrianromeroAssigned To => alostale
2020-07-21 11:53adrianromeroOBNetwork customer => No
2020-07-21 11:53adrianromeroModules => Core
2020-07-21 11:53adrianromeroTriggers an Emergency Pack => No
2020-07-21 11:54adrianromeroRelationship addedcaused by 0044579
2020-07-21 11:57martinsdanIssue Monitored: martinsdan
2020-07-22 06:35alostaleTag Attached: Approved
2020-07-22 06:35alostaleAssigned Toalostale => adrianromero
2020-07-22 11:09hgbotResolutionopen => fixed
2020-07-22 11:09hgbotStatusnew => resolved
2020-07-22 11:09hgbotNote Added: 0121563
2020-07-22 11:13adrianromeroReview Assigned To => guilleaer
2020-07-23 12:04guilleaerNote Added: 0121583
2020-07-23 12:04guilleaerStatusresolved => closed
2020-07-23 12:04guilleaerFixed in Version => PR20Q4

Notes
(0121563)
hgbot   
2020-07-22 11:09   
Repository: https://gitlab.com/openbravo/ci/backoffice-api [^]
Changeset: 64c65ac2b95d9d3db71b74fd69213d6d4dc3a19d
Author: Adrián Romero <adrian.romero@openbravo.com>
Date: 2020-07-22T09:56:37+02:00
URL: https://gitlab.com/openbravo/ci/backoffice-api/-/commit/64c65ac2b95d9d3db71b74fd69213d6d4dc3a19d [^]

Fixes ISSUE-0044645: API Change: Changed signature of method getProductIds() in class ImportProductInDiscount

---
M java/reference/java.japi.gz
---
(0121583)
guilleaer   
2020-07-23 12:04   
Closed.

API change approved by ALO