Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044639Retail ModulesWeb POSpublic2020-07-20 14:162020-08-11 13:57
Reporterjorge-garcia 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q4 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044639: Inconsistent behavior with "Do not allow Sales with return" preference
DescriptionWhen the preference "Do not allow Sales with return" is set, some strange behaviors has been detected in particular with Verified Returns feature
Steps To Reproduce1) Login in ERP
  1.1) Set a new "Do not allow Sales with return" preference to value N
2) Login in WebPOS
  2.1) Add one line to the ticket and click on Return this line
    2.1.1) The order seems to be a Sales Order (No "To be returned" tag is shown)
  2.2) Delete the ticket
  2.3) Create a sales order with one line and pay it completely. Click on Done button to finish the sale
  2.4) Go to Verified Return ticket and select previous created Sales Order. Select all lines and click on Apply
    2.4.1) A new negative line is created with the referenced order. The order seems to be a Sales Order (No "To be returned" tag is shown).
3) Login again in ERP
  3.1) Change previous "Do not allow Sales with return" value to Y
4) Login or refresh WebPOS
  4.1) Add one line to the ticket and click on Return this line
    4.1.1) The order seems to be a Return Order ("To be returned" tag is shown) -> This is OK
  4.2) Delete the ticket
  4.3) Create a sales order with one line and pay it completely. Click on Done button to finish the sale
  4.4) Go to Verified Return ticket and select previous created Sales Order. Select all lines and click on Apply
    4.4.1) A new negative line is created with the referenced order. The order seems to be a Sales Order (No "To be returned" tag is shown) -> This is WRONG.
  4.5) Now, try to add a new product
    4.5.1)An error message is shown at the top right corner of the application that indicates you cannot add a negative line to a ticket --> This is OK
  4.6) Delete this ticket and create a new ticket and add one line
  4.7) Click on Verified Return menu entry
    4.7.1) An error message is shown at the top right corner of the application that indicates you cannot add a negative line to a ticket --> This is OK
Proposed SolutionA patch has been attached to this issue as possible solution.

The patch changes the orderType of the receipt if the preference is set, the ticket has no lines (i.e. new ticket) and Verified Return menu entry is clicked.
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff 19Q3.4_possibleFix.diff (874) 2020-07-20 14:16
https://issues.openbravo.com/file_download.php?file_id=14788&type=bug
Issue History
Date ModifiedUsernameFieldChange
2020-07-20 14:16jorge-garciaNew Issue
2020-07-20 14:16jorge-garciaAssigned To => Retail
2020-07-20 14:16jorge-garciaFile Added: 19Q3.4_possibleFix.diff
2020-07-20 14:16jorge-garciaOBNetwork customer => Gold
2020-07-20 14:16jorge-garciaResolution time => 1597010400
2020-07-20 14:16jorge-garciaTriggers an Emergency Pack => No
2020-08-06 18:04ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-08-09 05:12ranjith_qualiantech_comStatusnew => scheduled
2020-08-11 07:43hgbotMerge Request Status => open
2020-08-11 07:43hgbotNote Added: 0121962
2020-08-11 07:43hgbotNote Added: 0121963
2020-08-11 13:57hgbotMerge Request Statusopen => approved
2020-08-11 13:57hgbotResolutionopen => fixed
2020-08-11 13:57hgbotNote Added: 0121978
2020-08-11 13:57hgbotStatusscheduled => closed
2020-08-11 13:57hgbotFixed in Version => RR20Q4
2020-08-11 13:57hgbotNote Added: 0121979
2020-08-11 13:57hgbotNote Added: 0121980
2020-08-11 13:57hgbotNote Added: 0121981

Notes
(0121962)
hgbot   
2020-08-11 07:43   
Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/26 [^]
(0121963)
hgbot   
2020-08-11 07:43   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns/-/merge_requests/7 [^]
(0121978)
hgbot   
2020-08-11 13:57   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns/-/merge_requests/7 [^]
(0121979)
hgbot   
2020-08-11 13:57   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns [^]
Changeset: 8529944a8815bc686d81706928b05f9d13c51776
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-08-10T13:21:19+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns/-/commit/8529944a8815bc686d81706928b05f9d13c51776 [^]

Fixed ISSUE-44639: Receipt OrderType should be updated when adding verified returns
* With Pref. Do not allow sales with return, if verified return lines are added, receipt should be updated as return receipt

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---
(0121980)
hgbot   
2020-08-11 13:57   
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: ec261af7634251f920041fdb9ecfd506f5f02c8a
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-08-11T11:57:33+00:00
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/ec261af7634251f920041fdb9ecfd506f5f02c8a [^]

Verifies ISSUE-44639: Added automated test I44639_VerifyVerifiedReturnWithPref

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/I44639_VerifyVerifiedReturnWithPref.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/I40262_VerifyPOSNotBlockedAfterVerifiedReturn.java
---
(0121981)
hgbot   
2020-08-11 13:57   
Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/26 [^]