Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044625Openbravo ERPA. Platformpublic2020-07-17 10:322020-09-09 08:32
Reportercberner 
Assigned Toplatform 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR20Q4 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044625: Remove or fix xercesImpl.jar library to support eclipse java 11
DescriptionEclipse ecj compiler generates an error when xercesImpl.jar is present because it collides with JDK package org.w3c.dom.html. This jar is present in the ERP.

There's a bug reported on their website to fix this, but there seems to be no plan to fix it soon.[1]

This has to be fixed to support working with Eclipse on java 11.

[1] https://issues.apache.org/jira/browse/XERCESJ-1689 [^]
Steps To Reproduce1. Open an erp environment in Eclipse and set the compiler to Java 11.
2. Apply 44625_reproduce.diff attached to this issue.
3. Build project, errors should show up in the build process.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0049242 new Triage Platform Base Update and un-fork xercesImpl.jar xml parser 
blocks feature request 0044624 closed platform Remove Java 8 JDK Support and raise stack to Java 11 
blocks design defect 0044733 closed platform Tracking issue: Find and fix all jar libaries with split packages between classpath and system image (Forbidden since Java9) 
blocks defect 0044973 closed platform Stack Update for PR20Q4 release 
causes defect 0044999 closed caristu xercesImpl updated causes errors on install.source in JDK8 
Attached Filesdiff 44625_reproduce.diff (696) 2020-07-27 12:49
https://issues.openbravo.com/file_download.php?file_id=14829&type=bug
Issue History
Date ModifiedUsernameFieldChange
2020-07-17 10:32cbernerNew Issue
2020-07-17 10:32cbernerAssigned To => platform
2020-07-17 10:32cbernerModules => Core
2020-07-17 10:32cbernerTriggers an Emergency Pack => No
2020-07-17 10:32cbernerRelationship addedblocks 0044624
2020-07-17 10:33cbernerSummaryRemove or fix xercesImpl.jar to support eclipse java 11 => Remove or fix xercesImpl.jar library to support eclipse java 11
2020-07-17 10:33cbernerDescription Updatedbug_revision_view_page.php?rev_id=21364#r21364
2020-07-17 11:56cbernerNote Added: 0121505
2020-07-27 12:50cbernerFile Added: 44625_reproduce.diff
2020-07-27 12:53cbernerSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=21398#r21398
2020-07-31 13:54shuehnerRelationship addedblocks 0044733
2020-08-28 12:18hgbotNote Added: 0122421
2020-09-03 09:52caristuRelationship addedblocks 0044973
2020-09-07 07:10hgbotResolutionopen => fixed
2020-09-07 07:10hgbotStatusnew => closed
2020-09-07 07:10hgbotNote Added: 0122704
2020-09-07 07:10hgbotFixed in Version => PR20Q4
2020-09-07 07:10hgbotNote Added: 0122705
2020-09-07 10:39caristuIssue cloned0044999
2020-09-07 10:39caristuRelationship addedcauses 0044999
2020-09-07 17:58caristuStatusclosed => new
2020-09-07 17:58caristuResolutionfixed => open
2020-09-07 17:58caristuFixed in VersionPR20Q4 =>
2020-09-07 18:00caristuNote Added: 0122772
2020-09-09 08:32caristuReview Assigned To => caristu
2020-09-09 08:32caristuNote Added: 0122830
2020-09-09 08:32caristuStatusnew => closed
2020-09-09 08:32caristuResolutionopen => fixed
2020-09-09 08:32caristuFixed in Version => PR20Q4
2022-05-05 18:07shuehnerRelationship addedrelated to 0049242

Notes
(0121505)
cberner   
2020-07-17 11:56   
Some work has been done in this MR trying to remove it.
https://gitlab.com/openbravo/product/openbravo/-/merge_requests/103 [^]

Problem found: nekohtml depends on it, and removing this generates more problems.
(0122421)
hgbot   
2020-08-28 12:18   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/128 [^]
(0122704)
hgbot   
2020-09-07 07:10   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/128 [^]
(0122705)
hgbot   
2020-09-07 07:10   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: d1c5ec1eeac2370f9b2cce15859867e8d837e5ff
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 2020-09-03T14:14:29+02:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/d1c5ec1eeac2370f9b2cce15859867e8d837e5ff [^]

fixes BUG-44625: update xercesImpl library

  Update xercesImpl library to version 2.12.1. This version still
is not compatible with JDK11 as it already has a split package problem
with the org.w3c.dom.html. Note that there is a known issue[1] already
reported for this library to fix this.

  For this reason, apart from updating this library to the latest
version we are fixing the JDK11 split package problem by patching the
.jar library to remove the org.w3c.dom.html package which indeed only
contained a single class: HTMLDOMImplementation.

  [1] https://issues.apache.org/jira/browse/XERCESJ-1689 [^]

---
A lib/runtime/xercesImpl-2.12.1-patched.jar
M legal/Licensing.txt
M src-core/.classpath
M src-trl/.classpath
M src-wad/.classpath
R lib/runtime/xercesImpl.jar
---
(0122772)
caristu   
2020-09-07 18:00   
Reverted fix[1] as it causes problem in JDK8. See 0044999.

[1] https://gitlab.com/openbravo/product/openbravo/-/commit/04a8027732f7f54d6ce305ee02100a7f8724d924 [^]
(0122830)
caristu   
2020-09-09 08:32   
Finally the changes introduced with this issue has been reverted, and to solve the the split package problem, the current xerces library has been patched. See 0044999.