Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044579Openbravo ERP07. Sales managementpublic2020-07-08 13:132020-07-23 15:12
Reporterpsarobe 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0PR20Q2 
Target VersionFixed in VersionPR20Q4 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044579: Button to upload products: Window Discount and Promotions
DescriptionDue to this fix https://issues.openbravo.com/view.php?id=42267 [^]

Now you can to have different products with the same search key but in different legal entities.

Because of that, the button to upload products is failing because it is finding the product more than one time while getting the UUID.
Steps To ReproduceConfiguration:
- You need to have two product with the same search key (P1, P2--> same search key)
- P1 needs to be in legal entity 1 (or in the tree that belongs that legal entity)
- P2 need to be in legal entity 2 (or in the tree that belongs that legal entity)

Steps:
1. Go to discount and promotion winow
2. Create the header and select "price adjustment" as discount type
3. Create a csv file that contains the search key of P1 and P2
4. Upload the file using the button (Not the orange one)

Current behaviour: Gives an error saying non unique product
Expected behaviour: The system should upload the correct product depending on the natural tree of the organization of the header.
Proposed SolutionThe process needs to take into account the organization of the header of the discount and promotion, in fact, the natural tree of the organization of the header.
Additional Information
TagsNo tags attached.
Relationships
causes defect 0044645 closed adrianromero API Change: Changed signature of method getProductIds() in class ImportProductInDiscount 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-07-08 13:13psarobeNew Issue
2020-07-08 13:13psarobeAssigned To => marvintm
2020-07-08 13:13psarobeOBNetwork customer => Gold
2020-07-08 13:13psarobeTriggers an Emergency Pack => No
2020-07-08 13:20psarobeSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=21297#r21297
2020-07-08 13:20psarobeProposed Solution updated
2020-07-08 13:22martinsdanIssue Monitored: martinsdan
2020-07-15 08:56ranjith_qualiantech_comAssigned Tomarvintm => ranjith_qualiantech_com
2020-07-15 08:56ranjith_qualiantech_comStatusnew => scheduled
2020-07-17 06:25hgbotMerge Request Status => open
2020-07-17 06:25hgbotNote Added: 0121497
2020-07-17 08:28hgbotMerge Request Statusopen => approved
2020-07-17 08:29hgbotResolutionopen => fixed
2020-07-17 08:29hgbotStatusscheduled => closed
2020-07-17 08:29hgbotNote Added: 0121498
2020-07-17 08:29hgbotNote Added: 0121499
2020-07-17 14:41hgbotNote Added: 0121510
2020-07-20 04:54ranjith_qualiantech_comNote Added: 0121513
2020-07-20 04:54ranjith_qualiantech_comStatusclosed => new
2020-07-20 04:54ranjith_qualiantech_comResolutionfixed => open
2020-07-20 04:54ranjith_qualiantech_comStatusnew => scheduled
2020-07-21 11:54adrianromeroRelationship addedcauses 0044645
2020-07-22 11:09hgbotResolutionopen => fixed
2020-07-22 11:09hgbotStatusscheduled => closed
2020-07-22 11:09hgbotFixed in Version => PR20Q4
2020-07-22 11:09hgbotNote Added: 0121562
2020-07-23 15:03shuehnerProjectRetail Modules => Openbravo ERP
2020-07-23 15:04shuehnerModules => Core
2020-07-23 15:04shuehnerCategoryDiscounts and Promotions => 07. Sales management
2020-07-23 15:04shuehnerversionRR20Q2 =>
2020-07-23 15:12shuehnerversion => 3.0PR20Q2

Notes
(0121497)
hgbot   
2020-07-17 06:25   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/106 [^]
(0121498)
hgbot   
2020-07-17 08:29   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 2b70f9471dbbf6ed818e366101d551f4b0729c79
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-07-17T09:54:31+05:30
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/2b70f9471dbbf6ed818e366101d551f4b0729c79 [^]

Fixed issue-44579: Product should be filtered before Import in M_Offer_Product table
* Before importing product in M_Offer_Product table, product should be filtered with Client and Org

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/businesslogic/ImportProductInDiscount.java
---
(0121499)
hgbot   
2020-07-17 08:29   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/106 [^]
(0121510)
hgbot   
2020-07-17 14:41   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 0b564e7e7da257ff24bc4b9f6a6712585b837092
Author: Adrián Romero <adrian.romero@openbravo.com>
Date: 2020-07-17T14:40:46+02:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/0b564e7e7da257ff24bc4b9f6a6712585b837092 [^]

Revert "Fixed issue-44579: Product should be filtered before Import in M_Offer_Product table"

This reverts commit 2b70f9471dbbf6ed818e366101d551f4b0729c79.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/businesslogic/ImportProductInDiscount.java
---
(0121513)
ranjith_qualiantech_com   
2020-07-20 04:54   
Changes reverted due to try failure
(0121562)
hgbot   
2020-07-22 11:09   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 25e3cb6fa21dd368dfd2fb0bca55279c79ae1505
Author: Adrián Romero <adrian.romero@openbravo.com>
Date: 2020-07-22T11:07:37+02:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/25e3cb6fa21dd368dfd2fb0bca55279c79ae1505 [^]

Fixed ISSUE-44579: Product should be filtered before Import in M_Offer_Product table
    * Before importing product in M_Offer_Product table, product should be filtered with Client and Org

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/businesslogic/ImportProductInDiscount.java
---