Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044542Openbravo ERPA. Platformpublic2020-07-02 12:122020-09-21 14:06
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusmerged
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044542: Apply new HQL Style in AggregationDao.java
DescriptionAggregationDao.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-07-02 12:12inigo_lergaNew Issue
2020-07-02 12:12inigo_lergaAssigned To => inigo_lerga
2020-07-02 12:12inigo_lergaOBNetwork customer => No
2020-07-02 12:12inigo_lergaModules => Core
2020-07-02 12:12inigo_lergaTriggers an Emergency Pack => No
2020-07-02 12:13inigo_lergaRelationship addedrelated to 0041287
2020-07-02 12:13inigo_lergaStatusnew => scheduled
2020-07-09 15:35inigo_lergaNote Added: 0121377
2020-08-14 09:20hgbotNote Added: 0122047
2020-08-14 09:59hgbotMerge Request Status => open
2020-08-14 09:59hgbotNote Added: 0122049
2020-08-14 10:41hgbotResolutionopen => fixed
2020-08-14 10:41hgbotStatusscheduled => resolved
2020-08-14 10:41hgbotNote Added: 0122052
2020-08-14 10:41hgbotMerge Request Statusopen => merged
2020-08-14 10:41hgbotNote Added: 0122053
2020-08-14 11:16dmiguelezReview Assigned To => dmiguelez
2020-08-14 11:16dmiguelezNote Added: 0122058
2020-08-14 11:16dmiguelezStatusresolved => closed
2020-09-08 14:34hgbotStatusclosed => resolved
2020-09-08 14:34hgbotNote Added: 0122798
2020-09-21 14:06vmromanosNote Added: 0123265
2020-09-21 14:06vmromanosStatusresolved => closed

Notes
(0121377)
inigo_lerga   
2020-07-09 15:35   
--Test Plan Mantis HQL--
Execute locally the Junit tests contained in OBCFRAggregationTestSuite.java (module org.openbravo.certification.france.testing).
#In this moment the modified HQLs are executed.
(0122047)
hgbot   
2020-08-14 09:20   
Merge request closed: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev/-/merge_requests/1 [^]
(0122049)
hgbot   
2020-08-14 09:59   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev/-/merge_requests/8 [^]
(0122052)
hgbot   
2020-08-14 10:41   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev [^]
Changeset: 21063153aae38d55377a5705690766212c6bd829
Author: david.miguelez <david.miguelez@openbravo.com>
Date: 2020-08-14T09:19:46+02:00
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev/-/commit/21063153aae38d55377a5705690766212c6bd829 [^]

fixes BUG-44542:APplied new HQL style

---
M src/org/openbravo/certification/france/aggregation/AggregationDao.java
---
(0122053)
hgbot   
2020-08-14 10:41   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev/-/merge_requests/8 [^]
(0122058)
dmiguelez   
2020-08-14 11:16   
Code Review + Testing Ok
(0122798)
hgbot   
2020-09-08 14:34   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.certification.france [^]
Changeset: f5224785d5d69309ea9695694920a91112b45905
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 2020-09-08T14:04:02+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.certification.france/-/commit/f5224785d5d69309ea9695694920a91112b45905 [^]

Synchronized from development repo (rev 9f2178b)

Synchronized src-db
Updated jar
Synchronized JS files
Updated module hash
Updated module version to 1.0.110

-- Included changesets:
f2f343c Updated minor version to 1.0.110
34d5f92 Fixes ISSUE-44884: Reduce hashed json scope including only main ticket properties
7cf2a16 Updated module hash
68446f1 Related to ISSUE-44843: Fix jslint errors
b582563 Related to ISSUE-44843: Implement the TicketList model in the new state engine
4268332 [ticket-list] delete unneeded validations
ca30265 Updated module hash
abf01bd Fixed ISSUE-44785: New flag at Organization level to default terminal blockchain
3246341 Fixed BUG-44783: Log client's ID in Security Background
2106315 fixes BUG-44542:APplied new HQL style
3d2c5e4 Update module hash
daf6af4 Fixes ISSUE-44749: Run TicketInitialValidation only if terminal has blockchain initialized
cef7608 Fixes ISSUE-44748: Change isBlockchained column default value to false
42c9637 Fixes ISSUE-44669: Avoid client/org check when setting admin mode

---
A src-db/database/model/modifiedTables/AD_ORG.xml
A src-db/database/sourcedata/AD_AUXILIARINPUT.xml
A src-db/database/sourcedata/AD_FIELDGROUP.xml
M lib/runtime/org.openbravo.certification.france-1.0.jar
M src-db/database/model/triggers/OBCFR_OBPOS_APPLICATIONS_TRG.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MODULE.xml
M web/org.openbravo.certification.france/js/ticket/preOrderSaveFinishCancelLayawayHook.js
M web/org.openbravo.certification.france/js/ticket/preSyncReceiptHook.js
---
(0123265)
vmromanos   
2020-09-21 14:06   
Closed again after automatically opened by the robot