Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044535Retail ModulesDiscounts and Promotionspublic2020-07-01 18:362020-09-29 16:24
Reporterpsarobe 
Assigned Toprakashmurugesan88 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product VersionRR20Q2 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Toadrianromero
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044535: Core backoffice - button to add products - Discount and Promotion window
DescriptionIn the Discount and Promotions window there is one button to add massively products. This product is shown in the toolbar (not the orange one) when the product sub-tab is selected. See image1

When you click it, a popup is shown where you can select Import Mode. See image2

The option "Import and Replace" works in a wrong way. It deletes all the previous products (if any) and put the new ones coming in the file.

This behaviour is wrong. It should:
- Deactivate all products that already exist inside the tab
- Create the new products that come in the file
- Update the products that were already in the tab and match with the ones coming in the file. Update means:
  - Activate them
  - Update the new values (Fix price, %, Amount)
Steps To Reproduce1. Go to Discount and Promotion window
2. Create a header, for example price adjustment discount type
3. Go to Product Tab. Notice that a new button appears in the toolbar
4. Click and open it.
5. Upload a file with some products. A,B,C,D
6. Select whatever import mode. It is not important because it is the first time

Expected result: A,B,C,D are inserted in the product tab

7. Upload another file with products C,D
8. Select the import mode: Import and Replace. Click OK

Expected result: A,B are deactivated. C, D remains active
Current result: A,B are not present anymore (this is WRONG). C, D remains active
Proposed Solution
Additional Information
TagsNOR
Relationships
Attached Filespng image1.PNG (37,793) 2020-07-01 18:36
https://issues.openbravo.com/file_download.php?file_id=14726&type=bug
png

png image2.PNG (14,190) 2020-07-01 18:37
https://issues.openbravo.com/file_download.php?file_id=14727&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2020-07-01 18:36psarobeNew Issue
2020-07-01 18:36psarobeAssigned To => marvintm
2020-07-01 18:36psarobeFile Added: image1.PNG
2020-07-01 18:36psarobeTriggers an Emergency Pack => No
2020-07-01 18:37psarobeFile Added: image2.PNG
2020-07-01 18:49martinsdanIssue Monitored: martinsdan
2020-07-01 19:03marvintmResolution time => 1595368800
2020-07-06 08:13marvintmAssigned Tomarvintm => Retail
2020-07-13 15:34lmonrealNote Added: 0121418
2020-07-14 08:56prakashmurugesan88Assigned ToRetail => prakashmurugesan88
2020-07-14 08:57prakashmurugesan88Statusnew => scheduled
2020-07-14 12:57hgbotNote Added: 0121436
2020-07-14 16:51adrianromeroNote Added: 0121446
2020-07-14 16:51adrianromeroStatusscheduled => resolved
2020-07-14 16:51adrianromeroResolutionopen => fixed
2020-07-14 16:51adrianromeroReview Assigned To => adrianromero
2020-07-14 16:51adrianromeroNote Added: 0121447
2020-07-14 16:51adrianromeroStatusresolved => closed
2020-07-14 16:59lmonrealRelationship addedblocks 0044608
2020-07-15 12:40guillermogilNote Added: 0121471
2020-07-15 12:40guillermogilStatusclosed => new
2020-07-15 12:40guillermogilResolutionfixed => open
2020-07-15 14:09hgbotNote Added: 0121477
2020-07-15 16:25hgbotResolutionopen => fixed
2020-07-15 16:25hgbotStatusnew => closed
2020-07-15 16:25hgbotNote Added: 0121481
2020-07-15 16:25hgbotNote Added: 0121482
2020-09-29 16:24rafarodaTag Attached: NOR

Notes
(0121418)
lmonreal   
2020-07-13 15:34   
Hello,

This case is also affecting Decathlon France, kindly please increase priority.
(0121436)
hgbot   
2020-07-14 12:57   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/100 [^]
(0121446)
adrianromero   
2020-07-14 16:51   
https://gitlab.com/openbravo/product/openbravo/-/commit/e3373a3bbb134824dd4a7bddd22ef58d7604db7d [^]
https://gitlab.com/openbravo/product/openbravo/-/commit/39503d76359006f2da501ee27900d63088de5678 [^]
(0121447)
adrianromero   
2020-07-14 16:51   
Verified
(0121471)
guillermogil   
2020-07-15 12:40   
Issue is not complete.
It is needed to update updated column to let POS take them into account on the incremental criteria
(0121477)
hgbot   
2020-07-15 14:09   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/104 [^]
(0121481)
hgbot   
2020-07-15 16:25   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: b46b24bb71eeadfbdc9eee1ab9a74c858438fd42
Author: prakash-1040 <prakash@qualiantech.com>
Date: 2020-07-15T19:06:38+05:30
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/b46b24bb71eeadfbdc9eee1ab9a74c858438fd42 [^]

Fixed BUG-44535: Included update and updated columns to take into account on the incremental criteria

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/businesslogic/ImportBPSet.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/businesslogic/ImportProductInDiscount.java
---
(0121482)
hgbot   
2020-07-15 16:25   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/104 [^]