Openbravo Issue Tracking System - Retail Modules
View Issue Details
0044490Retail ModulesWeb POSpublic2020-06-25 14:202020-12-17 03:32
shuehner 
ranjith_qualiantech_com 
normalminorhave not tried
closedfixed 
5
 
RR20Q4 
No
0044490: Remove overhead in URL's of authenticationClient & authenticationToken (multiserver related)
Those 2 values in request are part of code added to multiserver/storeserver to allow cross-server validation of requests/session.

However it seems to have a couple of bugs in practice
- Request are seen in which the 2 values are added multiple times in a single request (seen repeated up to 21 times)
For example seen in livebuild
/retail_modules_pgsql_pi/org.openbravo.mobile.core.checkServerA
vailability?authenticationClient=39363B0921BB4293B48383844325E84C&authenticationToken=<token>&authenticationClient=39363B0921BB4293B483
83844325E84C&authenticationToken=<token> now repeated 21 times

- Additionally those were only added to use in multi-server setup and should not be needed in single server install

Checking example big customer (19Q3)
- ca. 30% of GET URL length is only for those parameters (single copy of the values)
- 1.1M of 1.2M daily requests did have the token

As that causes some non-trivial overhead for (upload bandwidth, log-file volume, extra work for log-file parsing) maybe the feature should be completely disabled .
Concrete steps how to get WebPOS to add those are not known.
However checking logs of livebuilds it seems quite typical to happen every day during usage
a.) Double check that those values are not useful with single-server setup
b.) Disable / remove the feature as being obsolete
No tags attached.
diff 44490_20Q1_mobilecore.diff (15,239) 2020-12-17 03:32
https://issues.openbravo.com/file_download.php?file_id=15169&type=bug
Issue History
2020-06-25 14:20shuehnerNew Issue
2020-06-25 14:20shuehnerAssigned To => Retail
2020-06-25 14:20shuehnerResolution time => 1596146400
2020-06-25 14:20shuehnerTriggers an Emergency Pack => No
2020-08-17 07:22ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-08-17 09:16ranjith_qualiantech_comStatusnew => scheduled
2020-08-18 03:51hgbotNote Added: 0122107
2020-08-18 08:28hgbotResolutionopen => fixed
2020-08-18 08:28hgbotStatusscheduled => closed
2020-08-18 08:28hgbotNote Added: 0122120
2020-08-18 08:28hgbotFixed in Version => RR20Q4
2020-08-18 08:28hgbotNote Added: 0122121
2020-12-17 03:32ranjith_qualiantech_comFile Added: 44490_20Q1_mobilecore.diff

Notes
(0122107)
hgbot   
2020-08-18 03:51   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/51 [^]
(0122120)
hgbot   
2020-08-18 08:28   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/51 [^]
(0122121)
hgbot   
2020-08-18 08:28   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: fbd5c4207b0cf6fa5ed4170b158089547f84ffd3
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-08-18T11:37:57+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/fbd5c4207b0cf6fa5ed4170b158089547f84ffd3 [^]

Fixed ISSUE-44490: Removed obsolete Authentication info in ajax request
* New Ajax object should be created instead of reusing old for CheckServerAvailability function to avoid ajax param changes

---
M web/org.openbravo.mobile.core/source/component/dialog/ob-profile.js
M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
M web/org.openbravo.mobile.core/source/utils/ob-utilities.js
---