Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044479Retail ModulesGift cards and gift voucherspublic2020-06-24 17:592020-07-08 12:10
Reportersamuel_nicuesa 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in VersionRR20Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket16604
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044479: Javascript error using gift voucher
DescriptionJavascript error using gift voucher
Steps To Reproduce[BO]

Go to Product Window
Configure one product as Gift Voucher
Go to Price Tab and select the price list version setting the Unit price and list price 0.00
Go to Gift Voucher summary and include one product (Avalanche Transceiver)

[POS]

Login in WEB POS

Select the git voucher product
In the line, item properties pop up Select Gift Card Owner and one Identifier
Add the avalanche transceiver product and another product
Select the Gift Card voucher as payment
Select the previous gift voucher created
Click on the apply button
The error message will be shown (UNDEFINED Gift voucher with ID "" not found)
Click on menu drop down and select Gift / Credit Notes
Click on the search button and select the gift voucher
Click on the apply button and the javascript error message will happen.


I think this error is happening if the gift voucher product price is equal to 0.00
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-06-24 17:59samuel_nicuesaNew Issue
2020-06-24 17:59samuel_nicuesaAssigned To => Retail
2020-06-24 17:59samuel_nicuesaOBNetwork customer => No
2020-06-24 17:59samuel_nicuesaSupport ticket => 16604
2020-06-24 17:59samuel_nicuesaResolution time => 1594764000
2020-06-24 17:59samuel_nicuesaTriggers an Emergency Pack => No
2020-06-24 18:18samuel_nicuesaNote Added: 0121051
2020-07-05 18:01ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-07-07 10:26ngarciaOBNetwork customerNo => OBPS
2020-07-07 10:27ngarciaPrioritylow => urgent
2020-07-07 13:21ngarciaIssue Monitored: ngarcia
2020-07-08 06:13ranjith_qualiantech_comStatusnew => scheduled
2020-07-08 11:51hgbotCheckin
2020-07-08 11:51hgbotNote Added: 0121325
2020-07-08 11:51hgbotStatusscheduled => resolved
2020-07-08 11:51hgbotResolutionopen => fixed
2020-07-08 11:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/599d67ccfcfa3d1c5d1e961ac03518805761a86d [^]
2020-07-08 12:10marvintmReview Assigned To => marvintm
2020-07-08 12:10marvintmStatusresolved => closed
2020-07-08 12:10marvintmFixed in Version => RR20Q4

Notes
(0121051)
samuel_nicuesa   
2020-06-24 18:18   
Video
https://drive.google.com/file/d/1vEtPNA_6Q04fFQ_ONq4fkJ3TDg81Q5Se/view?usp=sharing [^]
(0121325)
hgbot   
2020-07-08 11:51   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 599d67ccfcfa3d1c5d1e961ac03518805761a86d
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Jul 08 15:20:35 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/599d67ccfcfa3d1c5d1e961ac03518805761a86d [^]

Fixed issue-44479: Order Lines should not be consumed if Voucher is closed

* When consuming GiftVoucher for n lines,
  if voucher is fully consumed for less than n lines,
  then remaining lines should not be validated for consumptions
* Updating Error message when consuming gift voucher

---
M src/org/openbravo/retail/giftcards/ConsumeGiftCardLines.java
M src/org/openbravo/retail/giftcards/GiftCardModel.java
M web/org.openbravo.retail.giftcards/js/components/GiftCardDetails.js
M web/org.openbravo.retail.giftcards/js/model/GiftCardUtils.js
---