Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044441Openbravo ERPA. Platformpublic2020-06-22 11:332022-03-04 11:22
Reporterinigo_lerga 
Assigned ToTriage Platform Conn 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044441: Apply new HQL Style in org.openbravo.authorize.net( CIMUtility.java & TransactionstatusDao.java)
DescriptionBoth files have one HQL query each which:
- are hard to read because of formatting
- and which are mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-06-22 11:33inigo_lergaNew Issue
2020-06-22 11:33inigo_lergaAssigned To => inigo_lerga
2020-06-22 11:33inigo_lergaModules => Core
2020-06-22 11:33inigo_lergaTriggers an Emergency Pack => No
2020-06-22 11:33inigo_lergaRelationship addedrelated to 0041287
2020-06-22 11:34inigo_lergaStatusnew => scheduled
2021-11-22 13:19shuehnerAssigned Toinigo_lerga => Triage Finance
2022-02-28 13:39vmromanosAssigned ToTriage Finance => Triage Platform Conn
2022-03-03 17:57shuehnerSummaryApply new HQL Style in CIMUtility.java => Apply new HQL Style in org.openbravo.authorize.net( CIMUtility.java & TransactionstatusDao.java)
2022-03-03 17:57shuehnerDescription Updatedbug_revision_view_page.php?rev_id=23719#r23719
2022-03-03 18:00hgbotNote Added: 0135436
2022-03-04 11:22hgbotResolutionopen => fixed
2022-03-04 11:22hgbotStatusscheduled => closed
2022-03-04 11:22hgbotNote Added: 0135463
2022-03-04 11:22hgbotNote Added: 0135464

Notes
(0135436)
hgbot   
2022-03-03 18:00   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.authorize.net/-/merge_requests/2 [^]
(0135463)
hgbot   
2022-03-04 11:22   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.authorize.net [^]
Changeset: 4fdfe69054895e204dec74c6beb23e6b69346652
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 03-03-2022 17:58:41
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.authorize.net/-/commit/4fdfe69054895e204dec74c6beb23e6b69346652 [^]

Fixes ISSUE-44441: Apply new HQL style

Apply new HQL style to two queries to make them constant strings and
improve readability.

---
M src/org/openbravo/authorize/net/process/cim/util/CIMUtility.java
M src/org/openbravo/authorize/net/process/transactiondetails/TransactionStatusDao.java
---
(0135464)
hgbot   
2022-03-04 11:22   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.authorize.net/-/merge_requests/2 [^]