0044375: EOL does not generate shipment lines automatically with step all.

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0044375

Retail Modules

Web POS

public

2020-06-05 14:11

2020-07-09 14:35

Reporter

gorkaion

Assigned To

ranjith_qualiantech_com

Priority

high

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

RR20Q2.1

Fixed in Version

RR20Q2.1

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Gold

Support ticket

16214

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0044375: EOL does not generate shipment lines automatically with step all.

Description

When step all is set on the EOL json the generateShipment flag is automatically set among others. It is also setting the deliver qty on all the lines based on the step.

This therefor tries to create the shipment for the order. But the shipment utils class is checking the isObposIsPaid flag status for each order line [1] which is set as false by default so no shipment line is created.

This can be a potential regression introduced in commit [2] by prepayments implementation. In previous releases it is not required to include any extra flag on the EOL json to generate the shipment.

[1] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/2a99f2895071f95d0e189c0fc31a821aedc1b659/src/org/openbravo/retail/posterminal/utility/ShipmentUtils.java#l207 [^]
[2] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a8ecf7965ff7 [^]

Steps To Reproduce

Process a EOL with step ALL.
Note that no shipment is generated.

Proposed Solution

The EOL should also set the isobpospaid flag to true when the shipment is required to be generated.

Additional Information