Openbravo Issue Tracking System - Retail Modules
View Issue Details
0044375Retail ModulesWeb POSpublic2020-06-05 14:112020-07-09 14:35
gorkaion 
ranjith_qualiantech_com 
highmajorhave not tried
closedfixed 
5
 
RR20Q2.1RR20Q2.1 
marvintm
No
0044375: EOL does not generate shipment lines automatically with step all.
When step all is set on the EOL json the generateShipment flag is automatically set among others. It is also setting the deliver qty on all the lines based on the step.

This therefor tries to create the shipment for the order. But the shipment utils class is checking the isObposIsPaid flag status for each order line [1] which is set as false by default so no shipment line is created.

This can be a potential regression introduced in commit [2] by prepayments implementation. In previous releases it is not required to include any extra flag on the EOL json to generate the shipment.


[1] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/2a99f2895071f95d0e189c0fc31a821aedc1b659/src/org/openbravo/retail/posterminal/utility/ShipmentUtils.java#l207 [^]
[2] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a8ecf7965ff7 [^]
Process a EOL with step ALL.
Note that no shipment is generated.
The EOL should also set the isobpospaid flag to true when the shipment is required to be generated.
No tags attached.
blocks defect 0044297 closed ranjith_qualiantech_com EOL does not generate shipment lines automatically with step all. 
Issue History
2020-06-16 16:28ranjith_qualiantech_comTypedefect => backport
2020-06-16 16:28ranjith_qualiantech_comTarget Version => RR20Q2.1
2020-06-19 09:46hgbotCheckin
2020-06-19 09:46hgbotNote Added: 0120918
2020-06-19 09:46hgbotStatusscheduled => resolved
2020-06-19 09:46hgbotResolutionopen => fixed
2020-06-19 09:46hgbotFixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR20Q2.1/org.openbravo.retail.posterminal/rev/d6373d8f2d085f5303e498099a7357f9ae1f27fd [^]
2020-06-29 12:39marvintmReview Assigned To => marvintm
2020-06-29 12:39marvintmStatusresolved => closed
2020-06-29 12:39marvintmFixed in Version => RR20Q2.1
2020-07-09 14:28hgbotStatusclosed => resolved
2020-07-09 14:28hgbotNote Added: 0121361
2020-07-09 14:35shuehnerNote Added: 0121368
2020-07-09 14:35shuehnerStatusresolved => closed

Notes
(0120918)
hgbot   
2020-06-19 09:46   
Repository: retail/backports/3.0RR20Q2.1/org.openbravo.retail.posterminal
Changeset: d6373d8f2d085f5303e498099a7357f9ae1f27fd
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Jun 17 12:03:11 2020 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR20Q2.1/org.openbravo.retail.posterminal/rev/d6373d8f2d085f5303e498099a7357f9ae1f27fd [^]

Fixed issue-44375 : OrderLine isPaid should be updated in ExternalOrderLoader

* In ExternalOrderLoader, if order is fully paid or paid on Credit, then
  lines isPaid should be updated as true

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0121361)
hgbot   
2020-07-09 14:28   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 832582222a5f4094511441db1efecd1b2fc749c7
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-07-09T12:28:04+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/832582222a5f4094511441db1efecd1b2fc749c7 [^]

Fixed issue-44375 : OrderLine isPaid should be updated in ExternalOrderLoader

* In ExternalOrderLoader, if order is fully paid or paid on Credit, then
  lines isPaid should be updated as true

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0121368)
shuehner   
2020-07-09 14:35   
Re-closing: Issues was just changed to resolved as side-effect of converting backport repos to gitlab release branch