Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044367Retail ModulesWeb POSpublic2020-06-16 13:142020-06-22 08:15
ReporterLeyre 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044367: EOL returns an error when the total amount of the transaction is zero.
DescriptionEOL returns an error when the total amount of the transaction is zero.
Steps To Reproduce1. Example - JSON:
{
"data": [
{
"step": "all",
"lines": [
{
"id": "qB20B9B61D0AEF0C3D211B6E91D1ABE1",
"qty": 1,
"lineNo": "10",
"product": "WVG/L0005",
"taxLines": {
"5235D8E99A2749EFA17A5C92A52AEFC6": {
"name": "Entregas IVA 21%",
"rate": 21,
"netAmount": 26.86,
"taxAmount": 5.64
}
},
"listPrice": 32.5,
"netAmount": 26.86,
"taxAmount": 5.64,
"promotions": [
],
"grossAmount": 32.5
},
{
"id": "qB20B9B61D0AEF0C3D211B6E91D1ABE2",
"qty": -1,
"lineNo": "10",
"product": "WVG/L0005",
"taxLines": {
"5235D8E99A2749EFA17A5C92A52AEFC6": {
"name": "Entregas IVA 21%",
"rate": 21,
"netAmount": -26.86,
"taxAmount": -5.64
}
},
"listPrice": 32.5,
"netAmount": -26.86,
"taxAmount": -5.64,
"promotions": [
],
"grossAmount": -32.5
}
],
"taxes": {
"5235D8E99A2749EFA17A5C92A52AEFC6": {
"name": "Entregas IVA 21%",
"rate": 21,
"netAmount": 26.86,
"taxAmount": 5.64
}
},
"currency": "EUR",
"payments": [
{
"date": "2019-04-05T08:52:00.423Z",
"kind": "OBPOS_payment.cash",
"rate": "1",
"isocode": "EUR",
"paidAmount": 0
}
],
"netAmount": 0,
"documentNo": "SO0000002",
"grossAmount": 0,
"hasbeenpaid": "Y",
"isQuotation": false,
"invoiceStatus": 100,
"businessPartner": "VBS/C0001",
"generateInvoice": true,
"pOSSBusinessDate": "2019-04-04T22:00:00.000Z",
"salesRepresentative": "E49545E7D0A2413E90C31C2CDC2153B1"
}
],
"channel": "External",
"messageId": "MSGID000005",
"posTerminal": "VBS-1"
}

2. Execute the previous information and verify in the Errors While Importing POS data that there is an error.

Proposed SolutionInformation:

org/openbravo/retail/posterminal/utility/InvoiceUtils.java:743
code:
final FIN_PaymentSchedule paymentScheduleInvoice = invoice.getFINPaymentScheduleList().get(0);

invoice.getFINPaymentScheduleList() = ""
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-06-16 13:14LeyreNew Issue
2020-06-16 13:14LeyreAssigned To => Retail
2020-06-16 13:14LeyreResolution time => 1594072800
2020-06-16 13:14LeyreTriggers an Emergency Pack => No
2020-06-16 16:15ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-06-18 12:03ranjith_qualiantech_comStatusnew => scheduled
2020-06-22 07:21hgbotCheckin
2020-06-22 07:21hgbotNote Added: 0120940
2020-06-22 07:21hgbotStatusscheduled => resolved
2020-06-22 07:21hgbotResolutionopen => fixed
2020-06-22 07:21hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/642aa3fba7058ff5a42ff266f62e32f54221c4e4 [^]
2020-06-22 08:15marvintmReview Assigned To => marvintm
2020-06-22 08:15marvintmStatusresolved => closed
2020-06-22 08:15marvintmFixed in Version => RR20Q3

Notes
(0120940)
hgbot   
2020-06-22 07:21   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 642aa3fba7058ff5a42ff266f62e32f54221c4e4
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jun 22 10:50:30 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/642aa3fba7058ff5a42ff266f62e32f54221c4e4 [^]

Fixed issue-44367: Update JSON IDs to upperCase in ExternalOrderLoader

* In Openbravo Standards, IDs should be uppercase, so IDS in json of EOL should be updated to uppercase

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---