Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044337Openbravo ERP09. Financial managementpublic2020-06-01 16:542020-06-10 18:02
Reportermaite 
Assigned Toinigo_lerga 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionPR20Q1.3Fixed in VersionPR20Q1.3 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket16232
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044337: Wrong posting in Settled Remittance Lines: cashvat information not generated when it should
DescriptionAs part of this issue (https://issues.openbravo.com/view.php?id=33973 [^]), new column ISPAIDATINVOICING is included in fin_payment_detail table. This column is not initialized so existent documents have it set to NULL

However, the "setInvoiceTaxCashVAT_V" method is only considering details having this column to FALSE (hql.append(" and itcv." + InvoiceTaxCashVAT_V.PROPERTY_ISPAIDATINVOICING + " = false");). So existent elements are not generating CASH VAT posting
Steps To Reproduce0. Environment older than 19Q3 (where ISPAIDATINVOICING does not exists)
1. Create CASH VAT sales invoice. Process and post it
2. Include this invoice in a remittance. Process and post it
3. Run Settle process to the previous remittance line
4. Upgrade environment to version >=19Q3
5. Access to settled the element and post it. Realize that CASH VAT accounting is NOT generated when it should
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0044255 closed inigo_lerga Wrong posting in Settled Remittance Lines: cashvat information not generated when it should 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-06-10 17:51dmiguelezTypedefect => backport
2020-06-10 17:51dmiguelezTarget Version => 3.0PR20Q1.3
2020-06-10 18:01hgbotCheckin
2020-06-10 18:01hgbotNote Added: 0120791
2020-06-10 18:01hgbotStatusscheduled => resolved
2020-06-10 18:01hgbotResolutionopen => fixed
2020-06-10 18:01hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/f97f1e168b23261b99ea33322ad122e60c56b691 [^] => http://code.openbravo.com/erp/backports/3.0PR20Q1.3/rev/997c774b062a8a97ef2a4f73bb8522b9a1d1e34b [^]
2020-06-10 18:02dmiguelezReview Assigned To => dmiguelez
2020-06-10 18:02dmiguelezNote Added: 0120792
2020-06-10 18:02dmiguelezStatusresolved => closed
2020-06-10 18:02dmiguelezFixed in Version => 3.0PR20Q1.3

Notes
(0120791)
hgbot   
2020-06-10 18:01   
Repository: erp/backports/3.0PR20Q1.3
Changeset: 997c774b062a8a97ef2a4f73bb8522b9a1d1e34b
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon Jun 08 09:31:31 2020 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR20Q1.3/rev/997c774b062a8a97ef2a4f73bb8522b9a1d1e34b [^]

fixes BUG-44337:Added null as possible value

New column ISPAIDATINVOICING now takes into account null
as a possible value in the query in charge of calculating
the linked InvoiceTaxCashVAT_V records and adding them to
the invoiceTaxCashVAT_V list associated.

---
M src/org/openbravo/erpCommon/ad_forms/DocLineCashVATReady_PaymentTransactionReconciliation.java
---
(0120792)
dmiguelez   
2020-06-10 18:02   
Code Review + Testing Ok