Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044336Openbravo ERP09. Financial managementpublic2020-06-01 16:542020-07-09 14:34
Reportermaite 
Assigned Toinigo_lerga 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionPR20Q2.1Fixed in VersionPR20Q2.1 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044336: Wrong posting in Settled Remittance Lines: cashvat information not generated when it should
DescriptionAs part of this issue (https://issues.openbravo.com/view.php?id=33973 [^]), new column ISPAIDATINVOICING is included in fin_payment_detail table. This column is not initialized so existent documents have it set to NULL

However, the "setInvoiceTaxCashVAT_V" method is only considering details having this column to FALSE (hql.append(" and itcv." + InvoiceTaxCashVAT_V.PROPERTY_ISPAIDATINVOICING + " = false");). So existent elements are not generating CASH VAT posting
Steps To Reproduce0. Environment older than 19Q3 (where ISPAIDATINVOICING does not exists)
1. Create CASH VAT sales invoice. Process and post it
2. Include this invoice in a remittance. Process and post it
3. Run Settle process to the previous remittance line
4. Upgrade environment to version >=19Q3
5. Access to settled the element and post it. Realize that CASH VAT accounting is NOT generated when it should
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0044255 closed inigo_lerga Wrong posting in Settled Remittance Lines: cashvat information not generated when it should 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-06-10 17:51dmiguelezTypedefect => backport
2020-06-10 17:51dmiguelezTarget Version => 3.0PR20Q2.1
2020-06-10 17:57hgbotCheckin
2020-06-10 17:57hgbotNote Added: 0120790
2020-06-10 17:57hgbotStatusscheduled => resolved
2020-06-10 17:57hgbotResolutionopen => fixed
2020-06-10 17:57hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/f97f1e168b23261b99ea33322ad122e60c56b691 [^] => http://code.openbravo.com/erp/backports/3.0PR20Q2.1/rev/8a0d42fa20fd0450cce654c9f090d21997c4f95c [^]
2020-06-10 18:02dmiguelezReview Assigned To => dmiguelez
2020-06-10 18:02dmiguelezNote Added: 0120793
2020-06-10 18:02dmiguelezStatusresolved => closed
2020-06-10 18:02dmiguelezFixed in Version => 3.0PR20Q2.1
2020-07-09 14:18hgbotStatusclosed => resolved
2020-07-09 14:18hgbotNote Added: 0121359
2020-07-09 14:34shuehnerNote Added: 0121366
2020-07-09 14:34shuehnerStatusresolved => closed

Notes
(0120790)
hgbot   
2020-06-10 17:57   
Repository: erp/backports/3.0PR20Q2.1
Changeset: 8a0d42fa20fd0450cce654c9f090d21997c4f95c
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Jun 09 18:15:47 2020 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR20Q2.1/rev/8a0d42fa20fd0450cce654c9f090d21997c4f95c [^]

Fixes ISSUE-44336: New column ISPAIDATINVOICING now takes
into account null as a possible value in the query in
charge of calculating the linked InvoiceTaxCashVAT_V
records and adding them to the invoiceTaxCashVAT_V list associated.

---
M src/org/openbravo/erpCommon/ad_forms/DocLineCashVATReady_PaymentTransactionReconciliation.java
---
(0120793)
dmiguelez   
2020-06-10 18:02   
Code Review + Testing Ok
(0121359)
hgbot   
2020-07-09 14:18   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: ab200e2e3b1c65b195d9aab92ea7c748d5f715ad
Author: Iñigo Lerga <inigo.lerga@openbravo.com>
Date: 2020-07-09T12:16:46+00:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/ab200e2e3b1c65b195d9aab92ea7c748d5f715ad [^]

Fixes ISSUE-44336: New column ISPAIDATINVOICING now takes
into account null as a possible value in the query in
charge of calculating the linked InvoiceTaxCashVAT_V
records and adding them to the invoiceTaxCashVAT_V list associated.

---
M src/org/openbravo/erpCommon/ad_forms/DocLineCashVATReady_PaymentTransactionReconciliation.java
---
(0121366)
shuehner   
2020-07-09 14:34   
Re-closing: Issues was just changed to resolved as side-effect of converting backport repos to gitlab release branch