Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044308Retail ModulesWeb POSpublic2020-06-08 16:592025-01-23 14:23
ReporterAgatheBertin 
Assigned Toprakashmurugesan88 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044308: Digital Coupon - When scanning barcode can't use coupon if no subtype for the issuing company
DescriptionLink to this one : https://issues.openbravo.com/view.php?id=44047 [^] ==> the scan part is missing


When scanning a barcode (not in manual mode), we should be able to use coupon even without subtype.
Steps To Reproduce- Create a Issuing Company (no subtypes)
In the POS
- add a product to the ticket
- Try to use a digital Coupon (with only scanning the barcode not manually)
http://wiki.openbravo.com/wiki/Projects:ChequeCadeau/User_Guide#Operation [^]
- Error Message "The sub Type is not valid for the selected issuing company"
Proposed Solution
Additional Information
TagsNOR
Relationships
related to defect 0044047 closed ranjith_qualiantech_com Digital Coupon - Can't use coupon if no subtype for the issuing company 
Attached Filespatch I44308_DigitalCouponWithoutSubtype.patch (2,560) 2020-06-10 13:45
https://issues.openbravo.com/file_download.php?file_id=14604&type=bug
patch issue 44308 source chequecadeau.patch (2,667) 2020-06-19 15:34
https://issues.openbravo.com/file_download.php?file_id=14659&type=bug
Issue History
Date ModifiedUsernameFieldChange
2020-06-08 16:59AgatheBertinNew Issue
2020-06-08 16:59AgatheBertinAssigned To => Retail
2020-06-08 16:59AgatheBertinOBNetwork customer => Gold
2020-06-08 16:59AgatheBertinResolution time => 1592776800
2020-06-08 16:59AgatheBertinTriggers an Emergency Pack => No
2020-06-08 17:02rafarodaRelationship addedrelated to 0044047
2020-06-08 17:03rafarodaTag Attached: NOR
2020-06-09 13:24ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-06-10 09:42prakashmurugesan88Assigned Toranjith_qualiantech_com => prakashmurugesan88
2020-06-10 09:42prakashmurugesan88Statusnew => scheduled
2020-06-10 13:40prakashmurugesan88File Added: I44308_DigitalCouponWithoutSubtype.patch
2020-06-10 13:44prakashmurugesan88File Deleted: I44308_DigitalCouponWithoutSubtype.patch
2020-06-10 13:45prakashmurugesan88File Added: I44308_DigitalCouponWithoutSubtype.patch
2020-06-17 16:39hgbotCheckin
2020-06-17 16:39hgbotNote Added: 0120893
2020-06-17 16:39hgbotStatusscheduled => resolved
2020-06-17 16:39hgbotResolutionopen => fixed
2020-06-17 16:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.chequecadeau/rev/a39209bc1d21a12ca385112c9d8d03f2c017cc81 [^]
2020-06-18 08:24marvintmReview Assigned To => marvintm
2020-06-18 08:24marvintmStatusresolved => closed
2020-06-18 08:24marvintmFixed in Version => RR20Q3
2020-06-19 15:34ranjith_qualiantech_comFile Added: issue 44308 source chequecadeau.patch
2020-06-19 15:43hgbotCheckin
2020-06-19 15:43hgbotNote Added: 0120932
2025-01-23 14:23hgbotNote Added: 0174589

Notes
(0120893)
hgbot   
2020-06-17 16:39   
Repository: erp/pmods/org.openbravo.retail.chequecadeau
Changeset: a39209bc1d21a12ca385112c9d8d03f2c017cc81
Author: Prakash M <prakash <at> qualiantech.com>
Date: Wed Jun 17 20:03:35 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.chequecadeau/rev/a39209bc1d21a12ca385112c9d8d03f2c017cc81 [^]

Fixed BUG-44308: Unable to scan digital coupon barcode without subtype for the
issuing company

* Code for empty subtype is '000000'
* On validating Coupon Code, skipped subtype validation if the subtype code in
coupon is '000000'

---
M web/org.openbravo.retail.chequecadeau/js/chequecadeauutils.js
---
(0120932)
hgbot   
2020-06-19 15:43   
Repository: erp/pmods/org.openbravo.retail.chequecadeau
Changeset: 68f30b98723a24c3fab91ed75a1600a3366bfd69
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Jun 19 19:10:55 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.chequecadeau/rev/68f30b98723a24c3fab91ed75a1600a3366bfd69 [^]

Related to issue-44308: Coupon can be added if subtype is not defined

* If Subtype is not defined for the issuing company, and if user scan the coupon code with Subtype then
  Coupon should be added as payment without Subtype.
  Subtype should not be validated if Subtype is not defined for the issuing company

---
M web/org.openbravo.retail.chequecadeau/js/chequecadeauutils.js
---
(0174589)
hgbot   
2025-01-23 14:23   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.chequecadeau/-/merge_requests/1 [^]