Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044296Retail ModulesDiscounts by Totalpublic2020-06-05 13:402020-06-12 16:16
Reporterdavidverrier 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionOpenbravo Appliance 14.04
Product Versionpi 
Target VersionFixed in VersionRR20Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerGold
Support ticket
Regression levelPre packaging ( pi )
Regression date2020-04-17
Regression introduced in releasepi
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/d1d8cf3395f8 [^]
Triggers an Emergency PackNo
Summary0044296: Cannot remove discount added manually
DescriptionWhen trying to remove a manually added discount in WebPOS, and error message is shown and it is impossible to remove the discount.

Uncaught TypeError: this.args.receipt.get.bytotalManualPromotions is not iterable
Steps To ReproduceWHEN I navigate to
https://livebuilds.openbravo.com/retail_modules_oracle_pi/web/org.openbravo.retail.posterminal/?terminal=VBS-1#retail.pointofsale [^]

AND I log in,
AND I add a product to the ticket,
AND I select the product on the ticket,
AND I add a manual discount,
AND I select the product on the ticket,
AND I delete the discount,
THEN I see an error message

Uncaught TypeError: this.args.receipt.get.bytotalManualPromotions is not iterable
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng Screenshot from 2020-06-05 13-40-05.png (823,684) 2020-06-05 13:40
https://issues.openbravo.com/file_download.php?file_id=14578&type=bug
Issue History
Date ModifiedUsernameFieldChange
2020-06-05 13:40davidverrierNew Issue
2020-06-05 13:40davidverrierAssigned To => Retail
2020-06-05 13:40davidverrierFile Added: Screenshot from 2020-06-05 13-40-05.png
2020-06-05 13:40davidverrierTriggers an Emergency Pack => No
2020-06-05 13:41guillermogilOBNetwork customer => Gold
2020-06-05 13:41guillermogilResolution time => 1592776800
2020-06-05 13:49ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-06-05 14:04ranjith_qualiantech_comRegression level => Pre packaging ( pi )
2020-06-05 14:04ranjith_qualiantech_comRegression date => 2020-04-17
2020-06-05 14:04ranjith_qualiantech_comRegression introduced in release => pi
2020-06-05 14:04ranjith_qualiantech_comRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/d1d8cf3395f8 [^]
2020-06-05 14:19ranjith_qualiantech_comStatusnew => scheduled
2020-06-05 14:23hgbotCheckin
2020-06-05 14:23hgbotNote Added: 0120711
2020-06-06 08:55ranjith_qualiantech_comStatusscheduled => resolved
2020-06-06 08:55ranjith_qualiantech_comResolutionopen => fixed
2020-06-12 16:16marvintmReview Assigned To => marvintm
2020-06-12 16:16marvintmStatusresolved => closed
2020-06-12 16:16marvintmFixed in Version => RR20Q3

Notes
(0120711)
hgbot   
2020-06-05 14:23   
Repository: erp/pmods/org.openbravo.retail.discounts.bytotal
Changeset: 52718f9ff0fcc9d3b793bfbb0e524874b536221b
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Jun 05 17:53:24 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/52718f9ff0fcc9d3b793bfbb0e524874b536221b [^]

Related to issue-44296 : Added validation to check bytotalManualPromotions exists

* When user deletes the discount, validation added to check
  whether bytotalManualPromotions is exists in the discounts list

---
M web/org.openbravo.retail.discounts.bytotal/js/deleteDiscountExtension.js
---