Openbravo Issue Tracking System - Modules
View Issue Details
0044295ModulesExternal Data Integrationpublic2020-06-05 13:372020-06-12 14:05
gorkaion 
caristu 
highmajoralways
closedfixed 
5
 
 
AugustoMauch
0044295: OutputWSRestProcessor does not define any timeout on the HttpURLConnection
When there is a call to a external WS using the OutputWSRestProcessor the connection is set without any timeout.

This can lead to severe issues when we are able to connect to the webservice but it does not return any response. In this case the process get stuck waiting a response holding a thread and database connection and making other Process Request waiting for it to finish. In case the request is executed asynchronously this means that a Import Entry thread gets hold indefinitely.
- Create a dummy webservice that does never return a response.
- Execute a EDL Request that in the Outout Process executes a call to the dummy webservice.
- Set some default timeout values that can be overriden by OutputWSRestProcessor implementors.
- Consider also implementing a generic timeout for the full process as there is not available any timeout for the full request duration so in case the webservice is returning a response very slow we don't wait till it finishes.
No tags attached.
Issue History
2020-06-05 13:37gorkaionNew Issue
2020-06-05 13:37gorkaionAssigned To => platform
2020-06-05 13:37gorkaionResolution time => 1582671600
2020-06-08 16:25gorkaionResolution time1582671600 => 1593122400
2020-06-11 18:42caristuAssigned Toplatform => caristu
2020-06-11 18:42caristuNote Added: 0120805
2020-06-12 09:05maiteIssue Monitored: maite
2020-06-12 14:05hgbotCheckin
2020-06-12 14:05hgbotNote Added: 0120830
2020-06-12 14:05hgbotCheckin
2020-06-12 14:05hgbotNote Added: 0120831
2020-06-12 14:05hgbotStatusnew => resolved
2020-06-12 14:05hgbotResolutionopen => fixed
2020-06-12 14:05hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/rev/6697add6e80abec3589ecad9a0d2ae8546daa83b [^]
2020-06-12 14:05caristuReview Assigned To => AugustoMauch
2020-06-12 14:05caristuStatusresolved => closed

Notes
(0120805)
caristu   
2020-06-11 18:42   
MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/merge_requests/3/ [^]
(0120830)
hgbot   
2020-06-12 14:05   
Repository: erp/pmods/org.openbravo.externaldata.integration
Changeset: d1a9aed96f2bab9b76cf57f8ebc75742a0f3055f
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Jun 11 16:59:07 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/rev/d1a9aed96f2bab9b76cf57f8ebc75742a0f3055f [^]

Related to BUG-44295: initial code improvements

---
M src/org/openbravo/externaldata/integration/process/OutputWSRestProcessor.java
---
(0120831)
hgbot   
2020-06-12 14:05   
Repository: erp/pmods/org.openbravo.externaldata.integration
Changeset: 6697add6e80abec3589ecad9a0d2ae8546daa83b
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Jun 11 18:33:17 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/rev/6697add6e80abec3589ecad9a0d2ae8546daa83b [^]

Fixes BUG-44295: Define OutputWSRestProcessor HTTP connection timeouts

---
M src-db/database/model/tables/OBEDL_CONFIG_OUTPUT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/externaldata/integration/process/OutputWSRestProcessor.java
---