Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0044265Openbravo ERPA. Platformpublic2020-06-02 16:262021-09-07 06:53
egoitz 
cberner 
normalcriticalalways
closedfixed 
5
 
PR20Q3 
alostale
Core
No
0044265: Grid timeout is not working on the popup for audit trail
Having a timeout for the queries of the grid defined on the Openbravo.properties, that value is not considered on the grids shown on the audit trail popups.
-On an environment with big amount of data and big amout of audit information.
-Define on Openbravo.properties a low value for the grid timeout
-open the popup for audit trail on a window that is being audited.

*Query is not killed after the timeout.
Performance
related to design defect 0040479 acknowledged platform Reimplement Audit Trail popup with 3.0 technology 
related to defect 0040449 closed jarmendariz 'Show audit trail' manual window has performance problems in environments with many business partners 
depends on backport 0044282PR20Q2.1 closed cberner Grid timeout is not working on the popup for audit trail 
depends on backport 0044283PR20Q1.3 closed cberner Grid timeout is not working on the popup for audit trail 
related to defect 0047590 closed alostale Grid timeout is not working on the popup for audit trail when getting deleted records 
Issue History
2020-06-02 16:26egoitzNew Issue
2020-06-02 16:26egoitzAssigned To => platform
2020-06-02 16:26egoitzModules => Core
2020-06-02 16:26egoitzResolution time => 1592258400
2020-06-02 16:26egoitzTriggers an Emergency Pack => No
2020-06-03 10:16egoitzSummaryGrid timeout is now working on the popup for audit trail => Grid timeout is not working on the popup for audit trail
2020-06-03 18:33cbernerAssigned Toplatform => cberner
2020-06-04 10:06alostaleTag Attached: Performance
2020-06-04 10:06alostaleRelationship addedrelated to 0040479
2020-06-04 10:07alostaleRelationship addedrelated to 0040449
2020-06-04 10:16cbernerStatusnew => scheduled
2020-06-04 10:27cbernerNote Added: 0120640
2020-06-04 10:27cbernerReview Assigned To => alostale
2020-06-04 11:37alostaleStatusscheduled => feedback
2020-06-04 11:37alostaleStatusfeedback => new
2020-06-04 11:38alostaleSeveritymajor => critical
2020-06-04 11:38alostaleStatusnew => scheduled
2020-06-04 12:13hgbotCheckin
2020-06-04 12:13hgbotNote Added: 0120645
2020-06-04 12:13hgbotStatusscheduled => resolved
2020-06-04 12:13hgbotResolutionopen => fixed
2020-06-04 12:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/45a22d23973d6bfb14514f5d58978d7879129bee [^]
2020-06-04 12:18alostaleStatusresolved => closed
2020-06-04 12:18alostaleFixed in Version => 3.0PR20Q3
2021-08-25 10:53egoitzRelationship addedrelated to 0047590
2021-09-07 06:53hgbotNote Added: 0131586

Notes
(0120640)
cberner   
2020-06-04 10:27   
Merge Request: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/80 [^]
(0120645)
hgbot   
2020-06-04 12:13   
Repository: erp/devel/pi
Changeset: 45a22d23973d6bfb14514f5d58978d7879129bee
Author: Cristian Berner <cristian.berner <at> openbravo.com>
Date: Thu Jun 04 10:11:08 2020 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/45a22d23973d6bfb14514f5d58978d7879129bee [^]

Fixes ISSUE-44265: Use grid timeout in audit trail popup grid queries

---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/JsonUtils.java
M src/org/openbravo/erpCommon/businessUtility/AuditTrailPopup.java
---
(0131586)
hgbot   
2021-09-07 06:53   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 448e3cec40b60c13179d889e1e09f29840eb79a1
Author: Asier Lostalé <asier.lostale@openbravo.com>
Date: 2021-08-31T08:50:00+02:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/448e3cec40b60c13179d889e1e09f29840eb79a1 [^]

fixed BUG-47590: grid timeout not applied in audit trail deleted rows

Although correct grid query profile was set by fix 45a22d23973d for
BUG-44265, it was not applied when displaying deleted records. The
reason is deleted records queries are generated as manual sql and
executed through the ExecuteQuery API. This API was not taking into
account profile timeouts.

This commit:
 * Makes ExecuteQuery aware of query timeouts.
 * Allows AuditTrailDeletedRecords.getDeletedRecords to throw the
   exceptions that might occur during query execution so the caller
   catches them displaying a message to the user.
 * Removes an unused AuditTrailDeletedRecords.getDeletedRecords
   overloaded method.

---
M src/org/openbravo/erpCommon/businessUtility/AuditTrailDeletedRecords.java
M src/org/openbravo/erpCommon/businessUtility/AuditTrailPopup.java
M src/org/openbravo/erpCommon/utility/ExecuteQuery.java
---