Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044246Retail ModulesWeb POSpublic2020-06-01 12:362020-06-03 13:04
Reporterguillermogil 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044246: OBPOS_Errors has the column Processing = "Y" forever
DescriptionThe OBPOS_Errors has the column Processing = "Y" forever, something which as no sense, Processing should be "Y" only some milliseconds / few seconds when record is being processed but for some reason it gets freezed to "Y" forever.
Steps To ReproduceThe problem can be reproduced by "forcing" an exception inside SaveDataActionHandler, by adding the following code:

        if (1 == 1) {
          throw new OBException("boom");
        }

after this line: JSONObject result = syncProcess.exec(data, true);
Proposed SolutionIn the "catch" of the main "try" in the class, we should rollbackAndClose the DAL session, then set all "processing" values of all OBPOSErrors to false, by using the setProcessNow method, and flush the connection.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-06-01 12:36guillermogilNew Issue
2020-06-01 12:36guillermogilAssigned To => Retail
2020-06-01 12:36guillermogilOBNetwork customer => Gold
2020-06-01 12:36guillermogilResolution time => 1592517600
2020-06-01 12:36guillermogilTriggers an Emergency Pack => No
2020-06-02 09:48ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-06-03 07:14ranjith_qualiantech_comStatusnew => scheduled
2020-06-03 07:14hgbotCheckin
2020-06-03 07:14hgbotNote Added: 0120557
2020-06-03 07:14hgbotStatusscheduled => resolved
2020-06-03 07:14hgbotResolutionopen => fixed
2020-06-03 07:14hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/39d28298f9cc3d4d7404145da143efde2bcb7c57 [^]
2020-06-03 13:04marvintmReview Assigned To => marvintm
2020-06-03 13:04marvintmStatusresolved => closed
2020-06-03 13:04marvintmFixed in Version => RR20Q3

Notes
(0120557)
hgbot   
2020-06-03 07:14   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 39d28298f9cc3d4d7404145da143efde2bcb7c57
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Jun 03 10:44:35 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/39d28298f9cc3d4d7404145da143efde2bcb7c57 [^]

Fixed issue-44246 : Added rollback for Save OBPOSError action if any error occurs

* When processing OBPOSErrors, if any error occurs,
  transaction should be rollbacked and OBPOSError processing should be updated as false

---
M src/org/openbravo/retail/posterminal/SaveDataActionHandler.java
---