Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044245ModulesAdvanced Warehouse Operationspublic2020-06-01 11:592020-06-08 12:41
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0044245: Apply new HQL Style in OrderLoaderPreAddShipmentLineHookImplementation.java
DescriptionOrderLoaderPreAddShipmentLineHookImplementation.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-06-01 11:59inigo_lergaNew Issue
2020-06-01 11:59inigo_lergaAssigned To => inigo_lerga
2020-06-01 11:59inigo_lergaRelationship addedrelated to 0041287
2020-06-01 11:59inigo_lergaStatusnew => scheduled
2020-06-02 13:21inigo_lergaNote Added: 0120543
2020-06-08 12:41hgbotCheckin
2020-06-08 12:41hgbotNote Added: 0120733
2020-06-08 12:41hgbotStatusscheduled => resolved
2020-06-08 12:41hgbotResolutionopen => fixed
2020-06-08 12:41hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.retailconnector/rev/ac9f51cfb30d2fc0c93a752fa7ee75a03847154e [^]
2020-06-08 12:41dmiguelezReview Assigned To => dmiguelez
2020-06-08 12:41dmiguelezNote Added: 0120734
2020-06-08 12:41dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0120543)
inigo_lerga   
2020-06-02 13:21   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO and
retail modules installed and working.

As Vall Blanca user in AWO Front End in AMS1001 terminal:
  - Press the Browse button and select any product desired.
    Press Checkout, Pay Total and Done buttons.
#In this moment the modified HQL is executed#
(0120733)
hgbot   
2020-06-08 12:41   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.retailconnector
Changeset: ac9f51cfb30d2fc0c93a752fa7ee75a03847154e
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon Jun 01 13:24:13 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.retailconnector/rev/ac9f51cfb30d2fc0c93a752fa7ee75a03847154e [^]

fixes BUG-44245:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/retailconnector/OrderLoaderPreAddShipmentLineHookImplementation.java
---
(0120734)
dmiguelez   
2020-06-08 12:41   
Code Review + Testing Ok