Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044240Retail ModulesDiscounts and Promotionspublic2020-05-19 11:542020-06-02 08:20
Reportersanti_lozano 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR20Q1.2Fixed in VersionRR20Q1.2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression levelProduction - QA Approved
Regression date2019-10-30
Regression introduced in releaseRR20Q1
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8010727b12224ff5cd51931cdd6ba6b79cd2015a [^]
Triggers an Emergency PackNo
Summary0044240: Override existing promotions overrides all lines
DescriptionOverride existing promotions overrides all discounts on lines of the ticket on Web POS instead of only the selected ones
This happens on 20Q1 and tip, but doesn't happen on 19Q4.4
As explained on the wiki the correct behavior is the previous one:
"Indicate if this discount will override existing promotions. If this field is checked, no more promotions will be applied to affected lines."
Steps To Reproduce1- Add first line with product "Adhesive body warmers"
2- Add second line with product "Alpine poles"
3- Go to menu "Receipt discounts"
4- Select discount disc_5_var_perc
5- Select first line, click "Override existing promotion" and apply
6- Review that the discount has been applied on the first line
7- Go to menu "Receipt discounts"
8- Select discount disc_5_var_perc
9- Select second line, click "Override existing promotion" and apply
10- Review that the discount has been applied on the second line but the discount on the first line has disappeared
Proposed SolutionThere was an issue related to this topic that could be the cause 42117
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0044100 closed ranjith_qualiantech_com Override existing promotions overrides all lines 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-29 17:01marvintmTypedefect => backport
2020-05-29 17:01marvintmTarget Version => RR20Q1.2
2020-06-01 17:08PracticsIssue Monitored: Practics
2020-06-02 08:15hgbotCheckin
2020-06-02 08:15hgbotNote Added: 0120515
2020-06-02 08:15hgbotStatusscheduled => resolved
2020-06-02 08:15hgbotResolutionopen => fixed
2020-06-02 08:15hgbotFixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR20Q1.2/org.openbravo.retail.posterminal/rev/74cc6f930f805d846e087608b8953bf82051c5a4 [^]
2020-06-02 08:15hgbotCheckin
2020-06-02 08:15hgbotNote Added: 0120516
2020-06-02 08:20marvintmReview Assigned To => marvintm
2020-06-02 08:20marvintmStatusresolved => closed
2020-06-02 08:20marvintmFixed in Version => RR20Q1.2

Notes
(0120515)
hgbot   
2020-06-02 08:15   
Repository: retail/backports/3.0RR20Q1.2/org.openbravo.retail.posterminal
Changeset: 74cc6f930f805d846e087608b8953bf82051c5a4
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Jun 02 11:45:15 2020 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR20Q1.2/org.openbravo.retail.posterminal/rev/74cc6f930f805d846e087608b8953bf82051c5a4 [^]

Fixed issue-44240 : Added validation when applying discount with override option

* When applying discount with Override existing promotions,
  all manualpromotions should be removed for the selected line before applying new promotion
* When opening discount tab, "Override existing promotions" check box should not be checked by default

---
M web/org.openbravo.retail.posterminal/js/discountsengine/pos/pos-discounts.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/ticketdiscount.js
---
(0120516)
hgbot   
2020-06-02 08:15   
Repository: retail/backports/3.0RR20Q1.2/pi-mobile
Changeset: 86210298b269f6f2d128893bacebac0204156484
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jun 01 05:42:26 2020 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR20Q1.2/pi-mobile/rev/86210298b269f6f2d128893bacebac0204156484 [^]

Verifies issue 44240 : Added Automated Test I44240_VerifyManualDiscounts

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/splitline/SplitLineWithManualPromo2Combined.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I44240_VerifyManualDiscounts.java
---