Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044238Retail ModulesMulti UPC/EAN for Productpublic2020-05-29 14:422020-06-12 13:45
Reporterrafaroda 
Assigned Toprakashmurugesan88 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044238: Multiupc scan is not filtering with "equals" but with "contains"
DescriptionMultiupc scan is not filtering with "equals" but with "contains"


So it brings the product even if you don't scan the whole UPC, which is wrong.
Steps To ReproduceSee video https://drive.google.com/file/d/1gQFWWsK6koQ0spCBvy9RtmOxPczsYEoA/view?usp=sharing [^]

1) In live builds backend, check product "Alpine skiing backpack 27 L" https://livebuilds.openbravo.com/retail_modules_pgsql_pi/?tabId=180&recordId=F7029D77812B442C98611AE5C898CA8E [^]
2) See its MultiUPC record = 120 https://livebuilds.openbravo.com/retail_modules_pgsql_pi/?tabId=1431434553B94B25BFB38FC76BDFD27A&recordId=861FA2A615B740BAA46E06C4EBFBF673 [^]
3) In WebPOS, type 120 in SCAN: brings the product, OK
4) In WebPOS, type 12 in SCAN: bring the product also, NOT OK
Proposed SolutionMultiupc scan must filter with "equals" criteria in the same way regular UPC
Additional Information
TagsNOR
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-29 14:42rafarodaNew Issue
2020-05-29 14:42rafarodaAssigned To => Retail
2020-05-29 14:42rafarodaTriggers an Emergency Pack => No
2020-06-01 06:44rafarodaTag Attached: NOR
2020-06-02 14:53rafarodaResolution time => 1592085600
2020-06-03 15:05prakashmurugesan88Assigned ToRetail => prakashmurugesan88
2020-06-03 15:05prakashmurugesan88Statusnew => scheduled
2020-06-04 12:58hgbotCheckin
2020-06-04 12:58hgbotNote Added: 0120648
2020-06-04 12:58hgbotCheckin
2020-06-04 12:58hgbotNote Added: 0120649
2020-06-05 06:34hgbotCheckin
2020-06-05 06:34hgbotNote Added: 0120680
2020-06-05 06:34hgbotCheckin
2020-06-05 06:34hgbotNote Added: 0120681
2020-06-05 06:39prakashmurugesan88Statusscheduled => resolved
2020-06-05 06:39prakashmurugesan88Resolutionopen => fixed
2020-06-12 13:45marvintmReview Assigned To => marvintm
2020-06-12 13:45marvintmStatusresolved => closed
2020-06-12 13:45marvintmFixed in Version => RR20Q3

Notes
(0120648)
hgbot   
2020-06-04 12:58   
Repository: erp/pmods/org.openbravo.retail.multiupc
Changeset: 8e4283be620396b3686ae968207f088789622500
Author: Prakash M <prakash <at> qualiantech.com>
Date: Thu Jun 04 16:24:01 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.multiupc/rev/8e4283be620396b3686ae968207f088789622500 [^]

Related to BUG-44238: Multiupc scan filters data with contains instead of equals

* Indexed db does not allow join with other tables
* To fix Comma(,) is added at the prefix and suffix of filter value.
* Also Comma(,) is added at the prefix and suffix of concatinated
'EM_Obmupc_Multiupc_Desc' value.
* Now it can be filtered only of any one of the multiple upc value matches the
filter value.

* Here Comma(,) is added at the prefix and suffix of filter value

---
M web/org.openbravo.retail.multiupc/js/extendUPCSearch.js
---
(0120649)
hgbot   
2020-06-04 12:58   
Repository: erp/pmods/org.openbravo.multiupc
Changeset: 2de459c94d4be21e1694cb3ba49e3a02b6d6139f
Author: Prakash M <prakash <at> qualiantech.com>
Date: Thu Jun 04 16:23:48 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.multiupc/rev/2de459c94d4be21e1694cb3ba49e3a02b6d6139f [^]

Related to BUG-44238: Multiupc scan filters data with contains instead of equals

* Indexed db does not allow join with other tables
* To fix Comma(,) is added at the prefix and suffix of filter value.
* Also Comma(,) is added at the prefix and suffix of concatinated
'EM_Obmupc_Multiupc_Desc' value.
* Now it can be filtered only of any one of the multiple upc value matches the
filter value.

* Here Comma(,) is added at the prefix and suffix of concatinated
'EM_Obmupc_Multiupc_Desc' value in eventhandler and modulescript

---
M build/classes/org/openbravo/multiupc/modulescript/PopulateMultiUPCDescription.class
M build/classes/org/openbravo/multiupc/modulescript/PopulateMultiUPCDescriptionData.class
M src-util/modulescript/src/org/openbravo/multiupc/modulescript/PopulateMultiUPCDescription.java
M src-util/modulescript/src/org/openbravo/multiupc/modulescript/PopulateMultiUPCDescription_data.xsql
M src/org/openbravo/multiupc/event/UpdateMultiUpcDescHandler.java
---
(0120680)
hgbot   
2020-06-05 06:34   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 9238392683df9ff4935961b79e024a82eb68f1a4
Author: Prakash M <prakash <at> qualiantech.com>
Date: Fri Jun 05 10:03:41 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9238392683df9ff4935961b79e024a82eb68f1a4 [^]

Related to BUG-44238: UPCEAN must be filtered with equals instead of contains

---
M web/org.openbravo.mobile.core/source/retail/component/ob-retail-searchproductcharacteristic.js
---
(0120681)
hgbot   
2020-06-05 06:34   
Repository: tools/automation/pi-mobile
Changeset: 106c27b48925e54f81801831dbcaf4c54c18b8a1
Author: Prakash M <prakash <at> qualiantech.com>
Date: Fri Jun 05 10:04:07 2020 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/106c27b48925e54f81801831dbcaf4c54c18b8a1 [^]

Related to BUG-44238: Fixed multiupc test

* Includes comma(,) in prefix and suffix of multiupc concatination

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/multiupc/I34304_VerifyMultiUPCOnSearch.java
---