0044236: Action Preparations for Model actions receives the whole State instead of the Model

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0044236

Retail Modules

Web POS

public

2020-05-29 10:47

2020-06-04 11:38

Reporter

jarmendariz

Assigned To

jarmendariz

Priority

high

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

RR20Q3

Fixed in Version

RR20Q3

Merge Request Status

Review Assigned To

caristu

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0044236: Action Preparations for Model actions receives the whole State instead of the Model

Description

To remain consistent with the implementation of pre/post hooks, action functions and Model hooks, action preparations should receive only the part of the State related to the model. An exception to this rule is the action preparation of a global action.

Steps To Reproduce

Create an action preparation for a Model action. For example:

OB.App.StateAPI.TerminalLog.addLog.addActionPreparation(
    async (state, payload) => {
      payload.max = state.TerminalLog.eventsMaximumNumber;
    }
);

Notice that you have to execute state.TerminalLog to access the TerminalLog properties. This should be the correct way:

OB.App.StateAPI.TerminalLog.addLog.addActionPreparation(
    async (terminalLog, payload) => {
      payload.max = terminalLog.eventsMaximumNumber;
    }
);

Proposed Solution

Additional Information