Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044230ModulesAdvanced Warehouse Operationspublic2020-05-28 15:232020-06-08 11:47
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0044230: Apply new HQL Style in TaskFilterForRule.java
DescriptionTaskFilterForRule.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-28 15:23inigo_lergaNew Issue
2020-05-28 15:23inigo_lergaAssigned To => inigo_lerga
2020-05-28 15:23inigo_lergaRelationship addedrelated to 0041287
2020-05-28 15:24inigo_lergaStatusnew => scheduled
2020-06-02 12:55inigo_lergaNote Added: 0120542
2020-06-08 11:46hgbotCheckin
2020-06-08 11:46hgbotNote Added: 0120729
2020-06-08 11:46hgbotStatusscheduled => resolved
2020-06-08 11:46hgbotResolutionopen => fixed
2020-06-08 11:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.operatorloadbalancing/rev/0f9e3a1ecd6cfb356facad0b1fa15c75a92113a7 [^]
2020-06-08 11:47dmiguelezReview Assigned To => dmiguelez
2020-06-08 11:47dmiguelezNote Added: 0120730
2020-06-08 11:47dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0120542)
inigo_lerga   
2020-06-02 12:55   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the OLBTestSuite.java JUnit tests file
from advancedwarehouseoperations.operatorloadbalancing.
#In this moment part of the modified HQL is executed#

Parts of the query cannot be easily executed nor tested.
(0120729)
hgbot   
2020-06-08 11:46   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.operatorloadbalancing
Changeset: 0f9e3a1ecd6cfb356facad0b1fa15c75a92113a7
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Fri May 29 12:14:06 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.operatorloadbalancing/rev/0f9e3a1ecd6cfb356facad0b1fa15c75a92113a7 [^]

fixes BUG-44230:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/operatorloadbalancing/ad_process/TaskFilterForRule.java
---
(0120730)
dmiguelez   
2020-06-08 11:47   
Code Review + Testing Ok