Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044226Retail ModulesDiscounts by Totalpublic2020-05-28 13:162020-06-17 08:33
ReporterLeyre 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044226: It is possible to modify the "Currency format" (in the "Organization" window) with a precision different from the original curre
DescriptionIt is possible to modify the "Currency format" (in the "Organization" window) with a precision different from the original currency.

This generates that the POS Terminal does not calculate correctly prices, discounts ...
Steps To ReproduceEXAMPLE: One decimal

Backend:
https://livebuilds.openbravo.com/retail_modules_pgsql_pi/ [^]

1) Navigate to Organization = Vall Blanca Store
2) Currency Format = #,##0.0
3) Configure a discount = Variable Discount per Total Amount -> amount = 10

Web POS:
https://livebuilds.openbravo.com/retail_modules_pgsql_pi/web/org.openbravo.retail.posterminal/?terminal=VBS-1 [^]

1) Add a product 1 -> price = 9.9
2) Add a product 2 -> price = 9.9
3) Add a product 3 -> price = 2.9
4) Add the previous discount

Actual Result -> By Total amount = 10.1
Proposed SolutionAdd a warning message in the Backend indicating that if the "Currency Format" field in the "Organization" window is modified, and has a different value than the "POS Precision" field in the "Currency" window, it can cause problems.
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch issue 44226 source posterminal.patch (8,387) 2020-06-10 12:15
https://issues.openbravo.com/file_download.php?file_id=14600&type=bug
Issue History
Date ModifiedUsernameFieldChange
2020-05-28 13:16LeyreNew Issue
2020-05-28 13:16LeyreAssigned To => Retail
2020-05-28 13:16LeyreResolution time => 1592431200
2020-05-28 13:16LeyreTriggers an Emergency Pack => No
2020-05-28 13:17LeyreFile Added: case1.png
2020-05-28 13:17LeyreFile Added: case2.png
2020-06-01 10:38ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-06-10 09:47LeyreSummaryThe "By Total" discount, is not calculated correctly with one/zero decimals. => It is possible to modify the "Currency format" (in the "Organization" window) with a precision different from the original curre
2020-06-10 09:47LeyreDescription Updatedbug_revision_view_page.php?rev_id=21173#r21173
2020-06-10 09:47LeyreSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=21175#r21175
2020-06-10 09:47LeyreProposed Solution updated
2020-06-10 09:47LeyreFile Deleted: case1.png
2020-06-10 09:47LeyreFile Deleted: case2.png
2020-06-10 12:14ranjith_qualiantech_comStatusnew => scheduled
2020-06-10 12:15ranjith_qualiantech_comFile Added: issue 44226 source posterminal.patch
2020-06-17 08:31hgbotCheckin
2020-06-17 08:31hgbotNote Added: 0120878
2020-06-17 08:31hgbotStatusscheduled => resolved
2020-06-17 08:31hgbotResolutionopen => fixed
2020-06-17 08:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f776601d4d07c127f78dfd814b86f55a75197a99 [^]
2020-06-17 08:33marvintmReview Assigned To => marvintm
2020-06-17 08:33marvintmStatusresolved => closed
2020-06-17 08:33marvintmFixed in Version => RR20Q3

Notes
(0120878)
hgbot   
2020-06-17 08:31   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f776601d4d07c127f78dfd814b86f55a75197a99
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Jun 17 12:01:07 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f776601d4d07c127f78dfd814b86f55a75197a99 [^]

Fixed issue-44226 : Added Callout to check Orgs CurrencyFormat with POS Precision

* If Orgs CurrencyFormat precision is not same as Currency POS Precision,
  then warning should be shown

---
M src-db/database/sourcedata/AD_CALLOUT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
A src/org/openbravo/retail/posterminal/ad_callouts/CheckOrgCurrencyFormatwithPOSPrecision.java
---