Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044225ModulesAdvanced Warehouse Operationspublic2020-05-28 13:122020-06-08 10:06
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0044225: Apply new HQL Style in PickingDistributionOrderIssue_ITTAlgorithmDao.java
DescriptionPickingDistributionOrderIssue_ITTAlgorithmDao.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-28 13:12inigo_lergaNew Issue
2020-05-28 13:12inigo_lergaAssigned To => inigo_lerga
2020-05-28 13:13inigo_lergaRelationship addedrelated to 0041287
2020-05-28 13:13inigo_lergaStatusnew => scheduled
2020-05-28 13:22inigo_lergaNote Added: 0120401
2020-06-08 10:05hgbotCheckin
2020-06-08 10:05hgbotNote Added: 0120722
2020-06-08 10:05hgbotStatusscheduled => resolved
2020-06-08 10:05hgbotResolutionopen => fixed
2020-06-08 10:05hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/832f9229548a793ce665897ba825701d4ded8b32 [^]
2020-06-08 10:06dmiguelezReview Assigned To => dmiguelez
2020-06-08 10:06dmiguelezNote Added: 0120723
2020-06-08 10:06dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0120401)
inigo_lerga   
2020-05-28 13:22   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the OBDOWithAWOTestSuite.java JUnit tests file
from advancedwarehouseoperations.distributionorders.
#In this moment the modified HQLs are executed#
(0120722)
hgbot   
2020-06-08 10:05   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: 832f9229548a793ce665897ba825701d4ded8b32
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu May 28 14:00:04 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/832f9229548a793ce665897ba825701d4ded8b32 [^]

fixes BUG-44225:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/ittalgorithm/implementation/PickingDistributionOrderIssue_ITTAlgorithmDao.java
---
(0120723)
dmiguelez   
2020-06-08 10:06   
Code Review + Testing Ok