Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044210Retail ModulesWeb POSpublic2020-05-27 12:182020-06-11 11:44
Reporteraferraz 
Assigned Toaferraz 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR20Q3Fixed in VersionRR20Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044210: Redefine Ticket price properties
DescriptionReplace price property in org.openbravo.api.ticket.BaseLine by following properties:
- grossListPrice: price of the product in the price list (in case price list includes taxes)
- netListPrice: price of the product in the price list (in case price list doesn't include taxes)
- baseGrossUnitPrice: price of the line, after price modifications and before discounts application (in case price list includes taxes)
- baseNetUnitPrice: price of the line, after price modifications and before discounts application (in case price list doesn't include taxes)
- grossUnitPrice: final gross price of the line, after price modifications and discounts application
- netUnitPrice: final net price of the line, after price modifications and discounts application
- grossUnitAmount: final gross amount of the line, after price modifications and discounts application
- netUnitAmount: final net amount of the line, after price modifications and discounts application.
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0044156RR20Q3 closed aferraz Use same Ticket API in Discount and Tax engine - Tax engine changes 
related to defect 0044181RR20Q3 closed aferraz Use same Ticket API in Discount and Tax engine - Discount engine changes 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-27 12:18aferrazNew Issue
2020-05-27 12:18aferrazAssigned To => aferraz
2020-05-27 12:18aferrazTriggers an Emergency Pack => No
2020-05-29 11:14aferrazSummaryReceipt model price properties cleanup in Web POS => Redefine Ticket price properties
2020-05-29 11:14aferrazDescription Updatedbug_revision_view_page.php?rev_id=21123#r21123
2020-05-29 11:14aferrazSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=21125#r21125
2020-05-29 11:22hgbotCheckin
2020-05-29 11:22hgbotNote Added: 0120462
2020-05-29 11:22hgbotCheckin
2020-05-29 11:22hgbotNote Added: 0120463
2020-05-29 11:23hgbotCheckin
2020-05-29 11:23hgbotNote Added: 0120464
2020-05-29 11:23hgbotStatusnew => resolved
2020-05-29 11:23hgbotResolutionopen => fixed
2020-05-29 11:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.api.ticket/rev/dd3d5bf483c382935a20d558cad2a6dd5955f99a [^]
2020-05-29 11:23hgbotCheckin
2020-05-29 11:23hgbotNote Added: 0120465
2020-05-29 11:23hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.api.ticket/rev/dd3d5bf483c382935a20d558cad2a6dd5955f99a [^] => http://code.openbravo.com/erp/pmods/org.openbravo.api.ticket/rev/1b72fc0212fa9fa9a0732f0353ee667c1d104ccc [^]
2020-05-29 11:23hgbotCheckin
2020-05-29 11:23hgbotNote Added: 0120466
2020-05-29 11:23hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.api.ticket/rev/1b72fc0212fa9fa9a0732f0353ee667c1d104ccc [^] => http://code.openbravo.com/erp/pmods/org.openbravo.api.ticket/rev/5f38fc6e9d7d70210052328f053d89692097eb2d [^]
2020-05-29 11:23hgbotCheckin
2020-05-29 11:23hgbotNote Added: 0120467
2020-05-29 11:23hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.api.ticket/rev/5f38fc6e9d7d70210052328f053d89692097eb2d [^] => http://code.openbravo.com/erp/pmods/org.openbravo.api.ticket/rev/573d6805e91fa2cc02166b49a9fbfe53c1f7d151 [^]
2020-05-29 11:23aferrazRelationship addedrelated to 0044156
2020-05-29 11:23aferrazRelationship addedrelated to 0044181
2020-05-29 11:39aferrazTarget Version => RR20Q3
2020-05-29 11:54aferrazReview Assigned To => marvintm
2020-06-04 16:58marvintmStatusresolved => closed
2020-06-04 16:58marvintmFixed in Version => RR20Q3
2020-06-04 19:29aferrazDescription Updatedbug_revision_view_page.php?rev_id=21151#r21151
2020-06-11 11:44hgbotCheckin
2020-06-11 11:44hgbotNote Added: 0120798

Notes
(0120462)
hgbot   
2020-05-29 11:22   
Repository: erp/pmods/org.openbravo.oms
Changeset: 0eb3a305fa05165c98db81b2b07c1dafa6412588
Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri May 29 11:19:22 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.oms/rev/0eb3a305fa05165c98db81b2b07c1dafa6412588 [^]

Related to ISSUE-44210: Do not set price property in InputOrder as it is not used by OMS

---
M src-test/resources/OBOMS_Input.json
M src-test/resources/OBOMS_Input_MNS.json
M src/org/openbravo/oms/api/InputOrder.java
---
(0120463)
hgbot   
2020-05-29 11:22   
Repository: erp/pmods/org.openbravo.retail.oms.orderconfirmation
Changeset: 78ba157686fd6e2ce4c548d5f6d9d8f6158344f4
Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri May 29 11:19:47 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.oms.orderconfirmation/rev/78ba157686fd6e2ce4c548d5f6d9d8f6158344f4 [^]

Related to ISSUE-44210: Do not set price property in InputOrderFromOrderExecutor as it is not used by OMS

---
M src/org/openbravo/retail/oms/orderconfirmation/background/InputOrderFromOrderExecutor.java
---
(0120464)
hgbot   
2020-05-29 11:23   
Repository: erp/pmods/org.openbravo.api.ticket
Changeset: dd3d5bf483c382935a20d558cad2a6dd5955f99a
Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri May 29 10:37:32 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.api.ticket/rev/dd3d5bf483c382935a20d558cad2a6dd5955f99a [^]

Fixes ISSUE-44210: Define grossUnitPrice/netUnitPrice in BaseLine

---
M src/org/openbravo/api/ticket/BaseLine.java
---
(0120465)
hgbot   
2020-05-29 11:23   
Repository: erp/pmods/org.openbravo.api.ticket
Changeset: 1b72fc0212fa9fa9a0732f0353ee667c1d104ccc
Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri May 29 10:42:55 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.api.ticket/rev/1b72fc0212fa9fa9a0732f0353ee667c1d104ccc [^]

Fixes ISSUE-44210: Define grossUnitAmount/netUnitAmount in BaseLine

---
M src/org/openbravo/api/ticket/BaseLine.java
---
(0120466)
hgbot   
2020-05-29 11:23   
Repository: erp/pmods/org.openbravo.api.ticket
Changeset: 5f38fc6e9d7d70210052328f053d89692097eb2d
Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri May 29 10:51:19 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.api.ticket/rev/5f38fc6e9d7d70210052328f053d89692097eb2d [^]

Fixes ISSUE-44210: Define grossListPrice/netListPrice in BaseLine

---
M src/org/openbravo/api/ticket/BaseLine.java
---
(0120467)
hgbot   
2020-05-29 11:23   
Repository: erp/pmods/org.openbravo.api.ticket
Changeset: 573d6805e91fa2cc02166b49a9fbfe53c1f7d151
Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri May 29 11:00:19 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.api.ticket/rev/573d6805e91fa2cc02166b49a9fbfe53c1f7d151 [^]

Fixes ISSUE-44210: Define baseGrossUnitPrice/baseNetUnitPrice in BaseLine

---
M src/org/openbravo/api/ticket/BaseLine.java
---
(0120798)
hgbot   
2020-06-11 11:44   
Repository: erp/pmods/org.openbravo.oms
Changeset: d923d4d76c54ee53e2136b8c84ca8e62a05d80c4
Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Jun 11 11:44:44 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.oms/rev/d923d4d76c54ee53e2136b8c84ca8e62a05d80c4 [^]

Related to ISSUE-44210: Remove date property from test jsons as it is not used in OMS yet

---
M src-test/resources/OBOMS_Input.json
M src-test/resources/OBOMS_Input_MNS.json
M src-test/resources/OBOMS_Input_SearchKey.json
---