Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044199Openbravo ERPA. Platformpublic2020-04-02 08:122020-06-04 16:46
Reporteralostale 
Assigned Tocberner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR20Q2Fixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044199: warnings compiling with Eclipse 2020-03
DescriptionCompiling Openbravo with Eclipse 2020-03 (ecj-4.15) using default Openbravo preferences produces some warnings.
Steps To ReproduceCompile with Eclipse 2020-03 (in this case base retail pack):
     [java] ----------
     [java] 1. WARNING in /home/alostale/ws/base/ob-pg/openbravo/modules/org.openbravo.mobile.core/src/org/openbravo/mobile/core/servercontroller/MobileServerRequestExecutor.java 
(at line 140)
     [java] 	BufferedReader reader = new BufferedReader(new InputStreamReader(is, "UTF-8"));
     
[java] 	               ^^^^^^
     [java] Resource leak: 'reader' is never closed
     [java] ----------
     [java] ----------
     [java] 2. WARNING in /home/alostale/ws/base/ob-pg/openbravo/modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/master/ProductProperty.java 
(at line 18)
     [java] 	import org.openbravo.retail.posterminal.master.Product;
     [java] 	       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     [java] The import org.openbravo.retail.posterminal.master.Product is never used
     [java] ----------
     [java] ----------
     [java] 3. WARNING in /home/alostale/ws/base/ob-pg/openbravo/modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/process/HasDeliveryServices.java 
(at line 19)
     [java] 	import org.openbravo.retail.posterminal.process.HasServices;
     [java] 	       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     [java] The import org.openbravo.retail.posterminal.process.HasServices is never used
     [java] ----------
     [java] ----------
     [java] 4. WARNING in /home/alostale/ws/base/ob-pg/openbravo/src-test/src/org/openbravo/test/webservice/BaseWSTest.java 
(at line 257)
     [java] 	BufferedReader reader = new BufferedReader(new InputStreamReader(is, "UTF-8"));
     
[java] 	               ^^^^^^
     [java] Resource leak: 'reader' is never closed
     [java] ----------
     [java] ----------
     [java] 5. WARNING in /home/alostale/ws/base/ob-pg/openbravo/src-test/src/org/openbravo/test/webservice/JSONWebServices.java 
(at line 134)
     [java] 	BufferedReader reader = new BufferedReader(new InputStreamReader(is, "UTF-8"));
     
[java] 	               ^^^^^^
     [java] Resource leak: 'reader' is never closed
     [java] ----------
     [java] 5 problems (5 warnings)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0043642 closed alostale warnings compiling with Eclipse 2020-03 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-26 17:52cbernerTypedefect => backport
2020-05-26 17:52cbernerTarget Version => 3.0PR20Q1.2
2020-05-26 17:54cbernerAssigned Toalostale => cberner
2020-05-26 18:59cbernerTarget Version3.0PR20Q1.2 => 3.0PR20Q2.1
2020-05-26 19:00hgbotCheckin
2020-05-26 19:00hgbotNote Added: 0120305
2020-05-26 19:00hgbotStatusscheduled => resolved
2020-05-26 19:00hgbotResolutionopen => fixed
2020-05-26 19:00hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.service.integration.magento.core/rev/00e2e7697d7aa77e9f6861ce54b2407b8168ca89 [^] => http://code.openbravo.com/erp/backports/3.0PR20Q2/rev/0e16c1a719fdeb2085ed619919f96cb3ca24c4ba [^]
2020-05-26 19:01hgbotCheckin
2020-05-26 19:01hgbotNote Added: 0120306
2020-05-26 19:02hgbotCheckin
2020-05-26 19:02hgbotNote Added: 0120307
2020-05-27 08:44ivancaceresIssue Monitored: ivancaceres
2020-05-27 09:51alostaleReview Assigned Tocaristu => alostale
2020-05-27 09:51alostaleNote Added: 0120335
2020-05-27 09:51alostaleStatusresolved => closed
2020-05-27 09:51alostaleFixed in Version => 3.0PR20Q2.1
2020-06-04 16:46plujanFixed in Version3.0PR20Q2.1 => 3.0PR20Q2
2020-06-04 16:46plujanTarget Version3.0PR20Q2.1 => 3.0PR20Q2

Notes
(0120305)
hgbot   
2020-05-26 19:00   
Repository: erp/backports/3.0PR20Q2
Changeset: 0e16c1a719fdeb2085ed619919f96cb3ca24c4ba
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Apr 03 13:43:26 2020 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR20Q2/rev/0e16c1a719fdeb2085ed619919f96cb3ca24c4ba [^]

Fixes ISSUE-44199: fixes some eclipse warns

---
M src-test/src/org/openbravo/test/webservice/BaseWSTest.java
M src-test/src/org/openbravo/test/webservice/JSONWebServices.java
---
(0120306)
hgbot   
2020-05-26 19:01   
Repository: retail/backports/3.0RR20Q2/org.openbravo.mobile.core
Changeset: 4277b0ac3de5541218d99f8d6c08a741bacab937
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Apr 13 08:50:07 2020 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR20Q2/org.openbravo.mobile.core/rev/4277b0ac3de5541218d99f8d6c08a741bacab937 [^]

Related to ISSUE-44199: fixes some eclipse warns

---
M src/org/openbravo/mobile/core/servercontroller/MobileServerRequestExecutor.java
---
(0120307)
hgbot   
2020-05-26 19:02   
Repository: retail/backports/3.0RR20Q2/org.openbravo.retail.posterminal
Changeset: f9f37fc14289c05c89bd7d81f76fb8a935014ece
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Apr 09 12:53:33 2020 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR20Q2/org.openbravo.retail.posterminal/rev/f9f37fc14289c05c89bd7d81f76fb8a935014ece [^]

Related to ISSUE-44199: fixes some eclipse warns

---
M src/org/openbravo/retail/posterminal/master/ProductProperty.java
M src/org/openbravo/retail/posterminal/process/HasDeliveryServices.java
---
(0120335)
alostale   
2020-05-27 09:51   
reviewed