Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044184ModulesAdvanced Warehouse Operationspublic2020-05-25 12:432020-06-05 12:21
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary0044184: Apply new HQL Style in TGC_DOI_Issue.java
DescriptionTGC_DOI_Issue.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-25 12:43inigo_lergaNew Issue
2020-05-25 12:43inigo_lergaAssigned To => inigo_lerga
2020-05-25 12:43inigo_lergaOBNetwork customer => No
2020-05-25 12:43inigo_lergaRelationship addedrelated to 0041287
2020-05-25 12:43inigo_lergaStatusnew => scheduled
2020-05-25 13:56inigo_lergaNote Added: 0120241
2020-06-05 12:20hgbotCheckin
2020-06-05 12:20hgbotNote Added: 0120699
2020-06-05 12:20hgbotStatusscheduled => resolved
2020-06-05 12:20hgbotResolutionopen => fixed
2020-06-05 12:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/200839c172977b1bd4cad5a6836de5f89bbeacb5 [^]
2020-06-05 12:20hgbotCheckin
2020-06-05 12:20hgbotNote Added: 0120700
2020-06-05 12:21dmiguelezReview Assigned To => dmiguelez
2020-06-05 12:21dmiguelezNote Added: 0120701
2020-06-05 12:21dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0120241)
inigo_lerga   
2020-05-25 13:56   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.

As the AWO-QA Admin - AWO-QA role in Backend:
  - Go to Distribution Order Issue window and create a new record
    with "US West Coast" as Warehouse Issue and "US East Coast"
    as Warehouse Receipt.
    Go to Lines Tab and create a new Line with "Ale Beer" as Product
    and 5 units as Operative Quantity.
    Save and Book the record.

As the AWO_US_W user in AWO Front End:
  - Press the Issue button and paste the previous Distribution Order
    Search Key in the search bar. Press the Search button.

#In this moment the modified HQL is executed#
(0120699)
hgbot   
2020-06-05 12:20   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: 200839c172977b1bd4cad5a6836de5f89bbeacb5
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon May 25 14:07:26 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/200839c172977b1bd4cad5a6836de5f89bbeacb5 [^]

fixes BUG-44184:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/feHooks/TGC_DOI_Issue.java
---
(0120700)
hgbot   
2020-06-05 12:20   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: 3a9091893f4c46bb9d18c9e8dd841c46dd804929
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Jun 05 12:20:32 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/3a9091893f4c46bb9d18c9e8dd841c46dd804929 [^]

Related to ISSUE-44184. Refactor to extract logic into different method

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/feHooks/TGC_DOI_Issue.java
---
(0120701)
dmiguelez   
2020-06-05 12:21   
Code Review + Testing Ok