Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044166ModulesAdvanced Warehouse Operationspublic2020-05-22 13:382020-06-04 16:58
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0044166: Apply new HQL Style in DistributionOrderBatchForPicking.java
DescriptionDistributionOrderBatchForPicking.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-22 13:38inigo_lergaNew Issue
2020-05-22 13:38inigo_lergaAssigned To => inigo_lerga
2020-05-22 13:39inigo_lergaRelationship addedrelated to 0041287
2020-05-22 13:39inigo_lergaStatusnew => scheduled
2020-05-25 14:15inigo_lergaNote Added: 0120244
2020-06-04 16:57hgbotCheckin
2020-06-04 16:57hgbotNote Added: 0120668
2020-06-04 16:57hgbotStatusscheduled => resolved
2020-06-04 16:57hgbotResolutionopen => fixed
2020-06-04 16:57hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.batchwavepicking/rev/e638d6d69f7ac5d2315053850566d9ca75107f16 [^]
2020-06-04 16:57hgbotCheckin
2020-06-04 16:57hgbotNote Added: 0120669
2020-06-04 16:58dmiguelezReview Assigned To => dmiguelez
2020-06-04 16:58dmiguelezNote Added: 0120670
2020-06-04 16:58dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0120244)
inigo_lerga   
2020-05-25 14:15   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the OBAWOPLTestSuite.java JUnit tests file
from advancedwarehouseoperations.batchwavepicking.
#In this moment the modified HQLs are executed#
(0120668)
hgbot   
2020-06-04 16:57   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.batchwavepicking
Changeset: e638d6d69f7ac5d2315053850566d9ca75107f16
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon May 25 14:11:37 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.batchwavepicking/rev/e638d6d69f7ac5d2315053850566d9ca75107f16 [^]

fixes BUG-44166:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/batchwavepicking/utils/DistributionOrderBatchForPicking.java
---
(0120669)
hgbot   
2020-06-04 16:57   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.batchwavepicking
Changeset: 4be7ecaf4c2dd9607b6c13a9a01dd39c0be67406
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Jun 04 16:57:35 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.batchwavepicking/rev/4be7ecaf4c2dd9607b6c13a9a01dd39c0be67406 [^]

Related to ISSUE-44166. Format changes to improve redability

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/batchwavepicking/utils/DistributionOrderBatchForPicking.java
---
(0120670)
dmiguelez   
2020-06-04 16:58   
Code Review + Testing Ok