Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044163ModulesAdvanced Warehouse Operationspublic2020-05-22 13:182020-06-04 16:06
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0044163: Apply new HQL Style in CheckStorageBinsInNonActiveSBGroup.java
DescriptionCheckStorageBinsInNonActiveSBGroup.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-22 13:18inigo_lergaNew Issue
2020-05-22 13:18inigo_lergaAssigned To => inigo_lerga
2020-05-22 13:18inigo_lergaRelationship addedrelated to 0041287
2020-05-22 13:19inigo_lergaStatusnew => scheduled
2020-05-22 13:36inigo_lergaNote Added: 0120181
2020-06-04 16:06hgbotCheckin
2020-06-04 16:06hgbotNote Added: 0120665
2020-06-04 16:06hgbotStatusscheduled => resolved
2020-06-04 16:06hgbotResolutionopen => fixed
2020-06-04 16:06hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/49ed5718ec7f43df5144d0140be4ce7d8def637e [^]
2020-06-04 16:06hgbotCheckin
2020-06-04 16:06hgbotNote Added: 0120666
2020-06-04 16:06dmiguelezReview Assigned To => dmiguelez
2020-06-04 16:06dmiguelezNote Added: 0120667
2020-06-04 16:06dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0120181)
inigo_lerga   
2020-05-22 13:36   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs are executed#
(0120665)
hgbot   
2020-06-04 16:06   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 49ed5718ec7f43df5144d0140be4ce7d8def637e
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Fri May 22 13:35:48 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/49ed5718ec7f43df5144d0140be4ce7d8def637e [^]

fixes BUG-44163:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehouseconfigurationcheck/implementation/CheckStorageBinsInNonActiveSBGroup.java
---
(0120666)
hgbot   
2020-06-04 16:06   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 5b0feee0e516afc4ff2a08c5fcfbcfcac2ee2d6a
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Jun 04 16:06:07 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/5b0feee0e516afc4ff2a08c5fcfbcfcac2ee2d6a [^]

Related to ISSUE-44163. Format changes to improve redability

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehouseconfigurationcheck/implementation/CheckStorageBinsInNonActiveSBGroup.java
---
(0120667)
dmiguelez   
2020-06-04 16:06   
Code Review + Testing Ok