Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044159ModulesAdvanced Warehouse Operationspublic2020-05-22 12:182020-06-04 13:53
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0044159: Apply new HQL Style in CheckStorageBinGroupListWithoutActiveStorageBinGroup.java
DescriptionCheckStorageBinGroupListWithoutActiveStorageBinGroup.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-22 12:18inigo_lergaNew Issue
2020-05-22 12:18inigo_lergaAssigned To => inigo_lerga
2020-05-22 12:18inigo_lergaRelationship addedrelated to 0041287
2020-05-22 12:19inigo_lergaStatusnew => scheduled
2020-05-22 12:38inigo_lergaNote Added: 0120177
2020-06-04 13:52hgbotCheckin
2020-06-04 13:52hgbotNote Added: 0120652
2020-06-04 13:52hgbotStatusscheduled => resolved
2020-06-04 13:52hgbotResolutionopen => fixed
2020-06-04 13:52hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/27cd3e5e8959d3212fb46687d6eb1174c1e7754a [^]
2020-06-04 13:52hgbotCheckin
2020-06-04 13:52hgbotNote Added: 0120653
2020-06-04 13:53dmiguelezReview Assigned To => dmiguelez
2020-06-04 13:53dmiguelezNote Added: 0120654
2020-06-04 13:53dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0120177)
inigo_lerga   
2020-05-22 12:38   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs are executed#
(0120652)
hgbot   
2020-06-04 13:52   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 27cd3e5e8959d3212fb46687d6eb1174c1e7754a
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Fri May 22 12:55:07 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/27cd3e5e8959d3212fb46687d6eb1174c1e7754a [^]

fixes BUG-44159:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehouseconfigurationcheck/implementation/CheckStorageBinGroupListWithoutActiveStorageBinGroup.java
---
(0120653)
hgbot   
2020-06-04 13:52   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: fb3d3d7ba031718af99aadd162ec81013d6e56a6
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Jun 04 13:52:41 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/fb3d3d7ba031718af99aadd162ec81013d6e56a6 [^]

Related to ISSUE-44159. Format changes to improve redability

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehouseconfigurationcheck/implementation/CheckStorageBinGroupListWithoutActiveStorageBinGroup.java
---
(0120654)
dmiguelez   
2020-06-04 13:53   
Code Review + Testing Ok