Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044154ModulesAdvanced Warehouse Operationspublic2020-05-22 11:452020-06-03 17:45
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0044154: Apply new HQL Style in CheckScheduledBackgroundProcesses.java
DescriptionCheckScheduledBackgroundProcesses.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-22 11:45inigo_lergaNew Issue
2020-05-22 11:45inigo_lergaAssigned To => inigo_lerga
2020-05-22 11:45inigo_lergaRelationship addedrelated to 0041287
2020-05-22 11:45inigo_lergaStatusnew => scheduled
2020-06-03 17:45hgbotCheckin
2020-06-03 17:45hgbotNote Added: 0120618
2020-06-03 17:45hgbotStatusscheduled => resolved
2020-06-03 17:45hgbotResolutionopen => fixed
2020-06-03 17:45hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/522819bdd3af48deab803496b038b371120dc55a [^]
2020-06-03 17:45hgbotCheckin
2020-06-03 17:45hgbotNote Added: 0120619
2020-06-03 17:45dmiguelezReview Assigned To => dmiguelez
2020-06-03 17:45dmiguelezNote Added: 0120620
2020-06-03 17:45dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0120618)
hgbot   
2020-06-03 17:45   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 522819bdd3af48deab803496b038b371120dc55a
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Fri May 22 11:58:53 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/522819bdd3af48deab803496b038b371120dc55a [^]

fixes BUG-44154:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehouseconfigurationcheck/implementation/CheckScheduledBackgroundProcesses.java
---
(0120619)
hgbot   
2020-06-03 17:45   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 78f1db9c3ca8c81797079f6127daa791060147a7
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Jun 03 17:45:13 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/78f1db9c3ca8c81797079f6127daa791060147a7 [^]

Related to ISSUE-44154. Format changes to improve redability and remove
unnecessary toString() call

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehouseconfigurationcheck/implementation/CheckScheduledBackgroundProcesses.java
---
(0120620)
dmiguelez   
2020-06-03 17:45   
Code Review + Testing Ok