Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044153ModulesAdvanced Warehouse Operationspublic2020-05-22 11:302020-06-03 17:34
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0044153: Apply new HQL Style in CheckProductAUMAreMultiples.java
DescriptionCheckProductAUMAreMultiples.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-22 11:30inigo_lergaNew Issue
2020-05-22 11:30inigo_lergaAssigned To => inigo_lerga
2020-05-22 11:32inigo_lergaRelationship addedrelated to 0041287
2020-05-22 11:32inigo_lergaStatusnew => scheduled
2020-05-22 11:43inigo_lergaNote Added: 0120169
2020-06-03 17:33hgbotCheckin
2020-06-03 17:33hgbotNote Added: 0120614
2020-06-03 17:33hgbotStatusscheduled => resolved
2020-06-03 17:33hgbotResolutionopen => fixed
2020-06-03 17:33hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/16d322d56872061f85d76a9d17ba10c8a25a8e33 [^]
2020-06-03 17:33hgbotCheckin
2020-06-03 17:33hgbotNote Added: 0120615
2020-06-03 17:34dmiguelezReview Assigned To => dmiguelez
2020-06-03 17:34dmiguelezNote Added: 0120616
2020-06-03 17:34dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0120169)
inigo_lerga   
2020-05-22 11:43   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs are executed#
(0120614)
hgbot   
2020-06-03 17:33   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 16d322d56872061f85d76a9d17ba10c8a25a8e33
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Fri May 22 11:47:45 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/16d322d56872061f85d76a9d17ba10c8a25a8e33 [^]

fixes BUG-44153:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehouseconfigurationcheck/implementation/CheckProductAUMAreMultiples.java
---
(0120615)
hgbot   
2020-06-03 17:33   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 4c4004d3d49729c04acba1b082280abb0d27259a
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Jun 03 17:33:36 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/4c4004d3d49729c04acba1b082280abb0d27259a [^]

Related to ISSUE-44153. Removed unnecessary toString() call

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehouseconfigurationcheck/implementation/CheckProductAUMAreMultiples.java
---
(0120616)
dmiguelez   
2020-06-03 17:34   
Code Review + Testing Ok