Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044149ModulesAdvanced Warehouse Operationspublic2020-05-22 09:372020-06-03 16:51
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0044149: Apply new HQL Style in CheckIRAWithoutRouting.java
DescriptionCheckIRAWithoutRouting.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-22 09:37inigo_lergaNew Issue
2020-05-22 09:37inigo_lergaAssigned To => inigo_lerga
2020-05-22 09:37inigo_lergaRelationship addedrelated to 0041287
2020-05-22 09:37inigo_lergaStatusnew => scheduled
2020-05-22 10:02inigo_lergaNote Added: 0120158
2020-06-03 16:51hgbotCheckin
2020-06-03 16:51hgbotNote Added: 0120605
2020-06-03 16:51hgbotStatusscheduled => resolved
2020-06-03 16:51hgbotResolutionopen => fixed
2020-06-03 16:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/9a888c14243ca21ed675309c425e4c33cd0b1671 [^]
2020-06-03 16:51hgbotCheckin
2020-06-03 16:51hgbotNote Added: 0120606
2020-06-03 16:51dmiguelezReview Assigned To => dmiguelez
2020-06-03 16:51dmiguelezNote Added: 0120607
2020-06-03 16:51dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0120158)
inigo_lerga   
2020-05-22 10:02   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs are executed#
(0120605)
hgbot   
2020-06-03 16:51   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 9a888c14243ca21ed675309c425e4c33cd0b1671
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Fri May 22 10:01:30 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/9a888c14243ca21ed675309c425e4c33cd0b1671 [^]

fixes BUG-44149:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehouseconfigurationcheck/implementation/CheckIRAWithoutRouting.java
---
(0120606)
hgbot   
2020-06-03 16:51   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 26cf583da581cacd0ba4e23123c60ca20112415a
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Jun 03 16:50:59 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/26cf583da581cacd0ba4e23123c60ca20112415a [^]

Related to ISSUE-44149: Fixes wrong formatter tag and makes changes
to format to improve redability

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehouseconfigurationcheck/implementation/CheckIRAWithoutRouting.java
---
(0120607)
dmiguelez   
2020-06-03 16:51   
Code Review + Testing Ok