Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044139ModulesAdvanced Warehouse Operationspublic2020-05-21 16:012020-06-03 16:34
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0044139: Apply new HQL Style in CheckForDefaultWAAssiForITT.java
DescriptionCheckForDefaultIRAssForITT.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-21 16:01inigo_lergaNew Issue
2020-05-21 16:01inigo_lergaAssigned To => inigo_lerga
2020-05-21 16:01inigo_lergaRelationship addedrelated to 0041287
2020-05-21 16:01inigo_lergaStatusnew => scheduled
2020-05-21 16:19inigo_lergaNote Added: 0120142
2020-06-03 16:33hgbotCheckin
2020-06-03 16:33hgbotNote Added: 0120602
2020-06-03 16:33hgbotStatusscheduled => resolved
2020-06-03 16:33hgbotResolutionopen => fixed
2020-06-03 16:33hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/a151b09e3e0cd739da321de75ee3ea64d344c72a [^]
2020-06-03 16:33hgbotCheckin
2020-06-03 16:33hgbotNote Added: 0120603
2020-06-03 16:34dmiguelezReview Assigned To => dmiguelez
2020-06-03 16:34dmiguelezNote Added: 0120604
2020-06-03 16:34dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0120142)
inigo_lerga   
2020-05-21 16:19   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs are executed#
(0120602)
hgbot   
2020-06-03 16:33   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: a151b09e3e0cd739da321de75ee3ea64d344c72a
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu May 21 16:23:08 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/a151b09e3e0cd739da321de75ee3ea64d344c72a [^]

fixes BUG-44139:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehouseconfigurationcheck/implementation/CheckForDefaultWAAssiForITT.java
---
(0120603)
hgbot   
2020-06-03 16:33   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: e23899d8b6d2fdb7e441428a99dedad4af0f5f4a
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Jun 03 16:33:23 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/e23899d8b6d2fdb7e441428a99dedad4af0f5f4a [^]

Related to ISSUE-44139. Removed some formatting on/off tags and
format changes to improve redability

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehouseconfigurationcheck/implementation/CheckForDefaultWAAssiForITT.java
---
(0120604)
dmiguelez   
2020-06-03 16:34   
Code Review + Testing Ok