Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044138ModulesAdvanced Warehouse Operationspublic2020-05-21 14:312020-06-03 13:52
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0044138: Apply new HQL Style in CheckForDefaultIRAssForITT.java
DescriptionCheckForDefaultIRAssForITT.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-21 14:31inigo_lergaNew Issue
2020-05-21 14:31inigo_lergaAssigned To => inigo_lerga
2020-05-21 14:32inigo_lergaRelationship addedrelated to 0041287
2020-05-21 14:32inigo_lergaStatusnew => scheduled
2020-05-21 15:56inigo_lergaNote Added: 0120139
2020-06-03 13:51hgbotCheckin
2020-06-03 13:51hgbotNote Added: 0120597
2020-06-03 13:51hgbotStatusscheduled => resolved
2020-06-03 13:51hgbotResolutionopen => fixed
2020-06-03 13:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/0879275e654ae257b1b3f827f02441c1e81ca298 [^]
2020-06-03 13:51hgbotCheckin
2020-06-03 13:51hgbotNote Added: 0120598
2020-06-03 13:52dmiguelezReview Assigned To => dmiguelez
2020-06-03 13:52dmiguelezNote Added: 0120599
2020-06-03 13:52dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0120139)
inigo_lerga   
2020-05-21 15:56   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs are executed#
(0120597)
hgbot   
2020-06-03 13:51   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 0879275e654ae257b1b3f827f02441c1e81ca298
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu May 21 15:57:47 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/0879275e654ae257b1b3f827f02441c1e81ca298 [^]

fixes BUG-44138:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehouseconfigurationcheck/implementation/CheckForDefaultIRAssForITT.java
---
(0120598)
hgbot   
2020-06-03 13:51   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 0f55b554b655da2aaa0b72e0ce81aed9e6919937
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Jun 03 13:51:41 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/0f55b554b655da2aaa0b72e0ce81aed9e6919937 [^]

Related to ISSUE-44138. Removed formatter on/off tags and format
changes to improve redability

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehouseconfigurationcheck/implementation/CheckForDefaultIRAssForITT.java
---
(0120599)
dmiguelez   
2020-06-03 13:52   
Code Review + Testing Ok