Openbravo Issue Tracking System - Modules
View Issue Details
0044135ModulesAdvanced Warehouse Operationspublic2020-05-21 13:252020-06-03 13:04
inigo_lerga 
inigo_lerga 
normalminorhave not tried
closedfixed 
5
 
 
dmiguelez
0044135: Apply new HQL Style in CheckBaseTaskTypeInITTAndIR.java
CheckBaseTaskTypeInITTAndIR.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
-
Follow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
No tags attached.
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Issue History
2020-05-21 13:25inigo_lergaNew Issue
2020-05-21 13:25inigo_lergaAssigned To => inigo_lerga
2020-05-21 13:25inigo_lergaRelationship addedrelated to 0041287
2020-05-21 13:25inigo_lergaStatusnew => scheduled
2020-05-21 14:17inigo_lergaNote Added: 0120135
2020-06-03 13:03hgbotCheckin
2020-06-03 13:03hgbotNote Added: 0120593
2020-06-03 13:03hgbotStatusscheduled => resolved
2020-06-03 13:03hgbotResolutionopen => fixed
2020-06-03 13:03hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/658d0da1a56c53996dca175127303bf4a9cebeb3 [^]
2020-06-03 13:03hgbotCheckin
2020-06-03 13:03hgbotNote Added: 0120594
2020-06-03 13:04dmiguelezReview Assigned To => dmiguelez
2020-06-03 13:04dmiguelezNote Added: 0120595
2020-06-03 13:04dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0120135)
inigo_lerga   
2020-05-21 14:17   
As the AWO-QA Admin - AWO-QA role in Backend:
  - Go to Warehouse Configuration Check window and
    select US as Organization.
    Press Done button.
#In this moment the modified HQL is executed#
(0120593)
hgbot   
2020-06-03 13:03   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 658d0da1a56c53996dca175127303bf4a9cebeb3
Author: IƱigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu May 21 14:28:27 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/658d0da1a56c53996dca175127303bf4a9cebeb3 [^]

fixes BUG-44135:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehouseconfigurationcheck/implementation/CheckBaseTaskTypeInITTAndIR.java
---
(0120594)
hgbot   
2020-06-03 13:03   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 5bbbfba0d02f9545a7dc0858ae357a8aa638f085
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Jun 03 13:03:25 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/5bbbfba0d02f9545a7dc0858ae357a8aa638f085 [^]

Related to ISSUE-44135. Removed formatter on/off tags and change
format to improve redability

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehouseconfigurationcheck/implementation/CheckBaseTaskTypeInITTAndIR.java
---
(0120595)
dmiguelez   
2020-06-03 13:04   
Code Review + Testing Ok