Openbravo Issue Tracking System - Modules
View Issue Details
0044134ModulesAdvanced Warehouse Operationspublic2020-05-21 12:252020-06-03 12:39
inigo_lerga 
inigo_lerga 
normalminorhave not tried
closedfixed 
5
 
 
dmiguelez
0044134: Apply new HQL Style in IncrementTaskPriorityProcessDao.java
IncrementTaskPriorityProcessDao.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
-
Follow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
No tags attached.
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Issue History
2020-05-21 12:25inigo_lergaNew Issue
2020-05-21 12:25inigo_lergaAssigned To => inigo_lerga
2020-05-21 12:26inigo_lergaStatusnew => scheduled
2020-05-21 12:26inigo_lergaRelationship addedrelated to 0041287
2020-05-21 12:46inigo_lergaNote Added: 0120128
2020-06-03 12:39hgbotCheckin
2020-06-03 12:39hgbotNote Added: 0120587
2020-06-03 12:39hgbotStatusscheduled => resolved
2020-06-03 12:39hgbotResolutionopen => fixed
2020-06-03 12:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/e98fde40eab48456c37d06ae71c0e51884b3fee6 [^]
2020-06-03 12:39dmiguelezReview Assigned To => dmiguelez
2020-06-03 12:39dmiguelezNote Added: 0120589
2020-06-03 12:39dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0120128)
inigo_lerga   
2020-05-21 12:46   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs are executed#
(0120587)
hgbot   
2020-06-03 12:39   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: e98fde40eab48456c37d06ae71c0e51884b3fee6
Author: IƱigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu May 21 12:52:07 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/e98fde40eab48456c37d06ae71c0e51884b3fee6 [^]

fixes BUG-44134:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehousealgorithm/process/IncrementTaskPriorityProcessDao.java
---
(0120589)
dmiguelez   
2020-06-03 12:39   
Code Review + Testing ok