Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044122ModulesAdvanced Warehouse Operationspublic2020-05-20 15:072020-06-03 12:23
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0044122: Apply new HQL Style in PK_QueryBuilder.java
DescriptionPK_QueryBuilder.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-20 15:07inigo_lergaNew Issue
2020-05-20 15:07inigo_lergaAssigned To => inigo_lerga
2020-05-20 15:07inigo_lergaRelationship addedrelated to 0041287
2020-05-20 15:07inigo_lergaStatusnew => scheduled
2020-06-03 12:23hgbotCheckin
2020-06-03 12:23hgbotNote Added: 0120582
2020-06-03 12:23hgbotStatusscheduled => resolved
2020-06-03 12:23hgbotResolutionopen => fixed
2020-06-03 12:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/9423b14ba203829fb533244e3e488de00768e83f [^]
2020-06-03 12:23hgbotCheckin
2020-06-03 12:23hgbotNote Added: 0120583
2020-06-03 12:23dmiguelezReview Assigned To => dmiguelez
2020-06-03 12:23dmiguelezNote Added: 0120584
2020-06-03 12:23dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0120582)
hgbot   
2020-06-03 12:23   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 9423b14ba203829fb533244e3e488de00768e83f
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed May 20 16:20:06 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/9423b14ba203829fb533244e3e488de00768e83f [^]

fixes BUG-44122:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehousealgorithm/PK_QueryBuilder.java
---
(0120583)
hgbot   
2020-06-03 12:23   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 5ad0dbf680c4ee69305fe0a290c02b88bde13d3e
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Jun 03 12:23:15 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/5ad0dbf680c4ee69305fe0a290c02b88bde13d3e [^]

Related to ISSUE-44122. Removed some formatter on/off tags,
as all the sentences belong to the same query and it is easier to
read it this way.

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehousealgorithm/PK_QueryBuilder.java
---
(0120584)
dmiguelez   
2020-06-03 12:23   
Code Review + Testing Ok