Openbravo Issue Tracking System - Modules
View Issue Details
0044119ModulesExternal Data Integrationpublic2020-05-20 13:112020-06-12 12:54
javietxe 
caristu 
normalmajorhave not tried
closedfixed 
5
 
 
https://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/rev/add838f2fe9e [^]
AugustoMauch
0044119: Output Content Not Saved In case of error
In an OUT integration towards a web service for example, everything goes fine but the ws we are sending the information responds an error.

The treatment of this error is done in the outputExtraActions method. If this response is not correct, the only way to set the Request in error is to throw an Exception.

As the treatment of all the exceptions in EDL is first to do a rollback, the output content generated is not stored in the database.

- Create an output integration with a WSRest configuration
- Send the content to the ws
- Do the WS respond a wrong response and treat it in the outputExtraActions method throwing an OBException.
- See that the OutputContent is not being stored
Create a new Exception type to distinguish it from a regular error in the EDL Process, so in this case the rollback is not needed.
No tags attached.
caused by defect 0042541 closed caristu EDL request status can be not updated properly under some circumnstances 
Issue History
2020-05-20 13:11javietxeNew Issue
2020-05-20 13:11javietxeAssigned To => platform
2020-05-20 13:11javietxeRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/rev/add838f2fe9e [^]
2020-05-20 13:11javietxeResolution time => 1591912800
2020-05-20 13:13caristuAssigned Toplatform => caristu
2020-05-20 13:13caristuRelationship addedcaused by 0042541
2020-05-26 09:37caristuNote Added: 0120265
2020-05-26 12:50caristuReview Assigned To => AugustoMauch
2020-06-12 12:53hgbotCheckin
2020-06-12 12:53hgbotNote Added: 0120823
2020-06-12 12:53hgbotStatusnew => resolved
2020-06-12 12:53hgbotResolutionopen => fixed
2020-06-12 12:53hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/rev/a30b69b3ae0bf1d0ee85fe52326abb2eeaf85e27 [^]
2020-06-12 12:54caristuStatusresolved => closed

Notes
(0120265)
caristu   
2020-05-26 09:37   
MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/merge_requests/2 [^]
(0120823)
hgbot   
2020-06-12 12:53   
Repository: erp/pmods/org.openbravo.externaldata.integration
Changeset: a30b69b3ae0bf1d0ee85fe52326abb2eeaf85e27
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue May 26 09:28:13 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/rev/a30b69b3ae0bf1d0ee85fe52326abb2eeaf85e27 [^]

fixes BUG-44119: Cancel EDL request line processing without rollback

  Added the ability of canceling the processing of an EDL request line
without doing rollback of the changes.

  Now this can be done by throwing the new ProcessInterruptedException
when it is desired to interrupt the line processing.

  Before fix of issue 0042541[1] it was possible to do the same with an
OBException, but this is a very common kind of exception that can not be
used to distinguish between an intended process cancelation and other
sources of error.

  For this reason we have now a dedicated exception that the
ProcessRequest handles to register the process as a failed one but
without doing rollback of the changes.

  [1] https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/merge_requests/1 [^]

---
M src/org/openbravo/externaldata/integration/process/ProcessRequest.java
A src/org/openbravo/externaldata/integration/process/ProcessInterruptedException.java
---