Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044100Retail ModulesDiscounts and Promotionspublic2020-05-19 11:542020-06-01 19:52
Reportersanti_lozano 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket16117
Regression levelProduction - QA Approved
Regression date2019-10-30
Regression introduced in releaseRR20Q1
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8010727b12224ff5cd51931cdd6ba6b79cd2015a [^]
Triggers an Emergency PackNo
Summary0044100: Override existing promotions overrides all lines
DescriptionOverride existing promotions overrides all discounts on lines of the ticket on Web POS instead of only the selected ones
This happens on 20Q1 and tip, but doesn't happen on 19Q4.4
As explained on the wiki the correct behavior is the previous one:
"Indicate if this discount will override existing promotions. If this field is checked, no more promotions will be applied to affected lines."
Steps To Reproduce1- Add first line with product "Adhesive body warmers"
2- Add second line with product "Alpine poles"
3- Go to menu "Receipt discounts"
4- Select discount disc_5_var_perc
5- Select first line, click "Override existing promotion" and apply
6- Review that the discount has been applied on the first line
7- Go to menu "Receipt discounts"
8- Select discount disc_5_var_perc
9- Select second line, click "Override existing promotion" and apply
10- Review that the discount has been applied on the second line but the discount on the first line has disappeared
Proposed SolutionThere was an issue related to this topic that could be the cause 42117
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0044239RR20Q2 closed ranjith_qualiantech_com Override existing promotions overrides all lines 
depends on backport 0044240RR20Q1.2 closed ranjith_qualiantech_com Override existing promotions overrides all lines 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-19 11:54santi_lozanoNew Issue
2020-05-19 11:54santi_lozanoAssigned To => Retail
2020-05-19 11:54santi_lozanoOBNetwork customer => OBPS
2020-05-19 11:54santi_lozanoSupport ticket => 16117
2020-05-19 11:54santi_lozanoResolution time => 1591653600
2020-05-19 11:54santi_lozanoTriggers an Emergency Pack => No
2020-05-19 12:05PracticsIssue Monitored: Practics
2020-05-22 10:26ngarciaTypebackport => defect
2020-05-29 11:59ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-05-29 14:23ranjith_qualiantech_comRegression level => Production - QA Approved
2020-05-29 14:23ranjith_qualiantech_comRegression date => 2019-10-30
2020-05-29 14:23ranjith_qualiantech_comRegression introduced in release => RR20Q1
2020-05-29 14:23ranjith_qualiantech_comRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8010727b12224ff5cd51931cdd6ba6b79cd2015a [^]
2020-05-29 17:01marvintmStatusnew => scheduled
2020-06-01 02:12hgbotCheckin
2020-06-01 02:12hgbotNote Added: 0120478
2020-06-01 02:12hgbotStatusscheduled => resolved
2020-06-01 02:12hgbotResolutionopen => fixed
2020-06-01 02:12hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/52afdf0322062ca7a994256f68e3ceb45729fd95 [^]
2020-06-01 02:12hgbotCheckin
2020-06-01 02:12hgbotNote Added: 0120479
2020-06-01 19:52marvintmReview Assigned To => marvintm
2020-06-01 19:52marvintmStatusresolved => closed
2020-06-01 19:52marvintmFixed in Version => RR20Q3

Notes
(0120478)
hgbot   
2020-06-01 02:12   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 52afdf0322062ca7a994256f68e3ceb45729fd95
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jun 01 05:42:12 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/52afdf0322062ca7a994256f68e3ceb45729fd95 [^]

Fixed issue-44100 : Added validation when applying discount with override option

* When applying discount with Override existing promotions,
  all manualpromotions should be removed for the selected line before applying new promotion
* When opening discount tab, "Override existing promotions" check box should not be checked by default

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/ticketdiscount.js
---
(0120479)
hgbot   
2020-06-01 02:12   
Repository: tools/automation/pi-mobile
Changeset: f99e0fa3351bdb73a463d23283dabe657afe366d
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jun 01 05:42:26 2020 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/f99e0fa3351bdb73a463d23283dabe657afe366d [^]

Verifies issue 44100 : Added Automated Test I44100_VerifyManualDiscounts

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/splitline/SplitLineWithManualPromo2Combined.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I44100_VerifyManualDiscounts.java
---