Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044099ModulesAdvanced Warehouse Operationspublic2020-05-19 11:512020-06-02 11:12
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary0044099: Apply new HQL Style in PhysicalInventoryProposalLinesCreator.java
DescriptionPhysicalInventoryProposalLinesCreator.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-19 11:51inigo_lergaNew Issue
2020-05-19 11:51inigo_lergaAssigned To => inigo_lerga
2020-05-19 11:51inigo_lergaOBNetwork customer => No
2020-05-19 11:51inigo_lergaRelationship addedrelated to 0041287
2020-05-19 11:51inigo_lergaStatusnew => scheduled
2020-05-19 12:08inigo_lergaNote Added: 0120030
2020-06-02 11:10hgbotCheckin
2020-06-02 11:10hgbotNote Added: 0120532
2020-06-02 11:10hgbotStatusscheduled => resolved
2020-06-02 11:10hgbotResolutionopen => fixed
2020-06-02 11:10hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/fe92aac807ee94861770b5684eebd82c7c1f43b3 [^]
2020-06-02 11:11hgbotCheckin
2020-06-02 11:11hgbotNote Added: 0120533
2020-06-02 11:12dmiguelezReview Assigned To => dmiguelez
2020-06-02 11:12dmiguelezNote Added: 0120534
2020-06-02 11:12dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0120030)
inigo_lerga   
2020-05-19 12:08   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs are executed#
(0120532)
hgbot   
2020-06-02 11:10   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: fe92aac807ee94861770b5684eebd82c7c1f43b3
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue May 19 12:20:05 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/fe92aac807ee94861770b5684eebd82c7c1f43b3 [^]

fixes BUG-44099:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/utils/inventorycount/PhysicalInventoryProposalLinesCreator.java
---
(0120533)
hgbot   
2020-06-02 11:11   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 9aa777d4a8ef47d8bb0e48067ff7ecd418b2c7de
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue Jun 02 11:09:45 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/9aa777d4a8ef47d8bb0e48067ff7ecd418b2c7de [^]

Related to ISSUE-44099. Format changes to improve redability

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/utils/inventorycount/PhysicalInventoryProposalLinesCreator.java
---
(0120534)
dmiguelez   
2020-06-02 11:12   
Code Review + Testing Ok