Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044096ModulesAdvanced Warehouse Operationspublic2020-05-19 10:592020-06-02 10:20
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0044096: Apply new HQL Style in InventoryCountGenerateList_Shared.java
DescriptionInventoryCountGenerateList_Shared.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-19 10:59inigo_lergaNew Issue
2020-05-19 10:59inigo_lergaAssigned To => inigo_lerga
2020-05-19 10:59inigo_lergaRelationship addedrelated to 0041287
2020-05-19 10:59inigo_lergaStatusnew => scheduled
2020-05-19 11:52inigo_lergaNote Added: 0120026
2020-06-02 10:19hgbotCheckin
2020-06-02 10:19hgbotNote Added: 0120529
2020-06-02 10:19hgbotStatusscheduled => resolved
2020-06-02 10:19hgbotResolutionopen => fixed
2020-06-02 10:19hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/efd8d3b5828e1fa4af02e1de1dbf7957d0b63540 [^]
2020-06-02 10:19hgbotCheckin
2020-06-02 10:19hgbotNote Added: 0120530
2020-06-02 10:20dmiguelezReview Assigned To => dmiguelez
2020-06-02 10:20dmiguelezNote Added: 0120531
2020-06-02 10:20dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0120026)
inigo_lerga   
2020-05-19 11:52   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs are executed#
(0120529)
hgbot   
2020-06-02 10:19   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: efd8d3b5828e1fa4af02e1de1dbf7957d0b63540
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue May 19 11:48:09 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/efd8d3b5828e1fa4af02e1de1dbf7957d0b63540 [^]

fixes BUG-44096:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/utils/inventorycount/InventoryCountGenerateList_Shared.java
---
(0120530)
hgbot   
2020-06-02 10:19   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 04d3333b8667f2bf43dc138a0bf37babc5997a43
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue Jun 02 10:19:38 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/04d3333b8667f2bf43dc138a0bf37babc5997a43 [^]

Related to ISSUE-44096. Format changes to improve redability

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/utils/inventorycount/InventoryCountGenerateList_Shared.java
---
(0120531)
dmiguelez   
2020-06-02 10:20   
Code Review + Testing Ok