Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044088ModulesAdvanced Warehouse Operationspublic2020-05-18 13:562020-06-01 18:00
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0044088: Apply new HQL Style in InventoryCount_StartRecount.java
DescriptionInventoryCount_StartRecount.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-18 13:56inigo_lergaNew Issue
2020-05-18 13:56inigo_lergaAssigned To => inigo_lerga
2020-05-18 13:56inigo_lergaRelationship addedrelated to 0041287
2020-05-18 13:57inigo_lergaStatusnew => scheduled
2020-05-18 16:12inigo_lergaNote Added: 0119992
2020-06-01 17:59hgbotCheckin
2020-06-01 17:59hgbotNote Added: 0120502
2020-06-01 17:59hgbotStatusscheduled => resolved
2020-06-01 17:59hgbotResolutionopen => fixed
2020-06-01 17:59hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/43d4f15e101eb8e5e7f6961aaab4b546695b65d2 [^]
2020-06-01 17:59hgbotCheckin
2020-06-01 17:59hgbotNote Added: 0120503
2020-06-01 18:00dmiguelezReview Assigned To => dmiguelez
2020-06-01 18:00dmiguelezNote Added: 0120504
2020-06-01 18:00dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0119992)
inigo_lerga   
2020-05-18 16:12   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs are executed#
(0120502)
hgbot   
2020-06-01 17:59   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 43d4f15e101eb8e5e7f6961aaab4b546695b65d2
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon May 18 15:59:44 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/43d4f15e101eb8e5e7f6961aaab4b546695b65d2 [^]

fixes BUG-44088:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/utils/inventorycount/InventoryCount_StartRecount.java
---
(0120503)
hgbot   
2020-06-01 17:59   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 15167861282bc6d000ec5afe43f3d1b500e73043
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Jun 01 17:59:45 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/15167861282bc6d000ec5afe43f3d1b500e73043 [^]

Related to ISSUE-44088. Format changes to improve redability

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/utils/inventorycount/InventoryCount_StartRecount.java
---
(0120504)
dmiguelez   
2020-06-01 18:00   
Code Review + Testing Ok