Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044085ModulesAdvanced Warehouse Operationspublic2020-05-18 13:212020-06-01 16:38
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary0044085: Apply new HQL Style in AWOReservationForTask.java
DescriptionAWOReservationForTask.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-18 13:21inigo_lergaNew Issue
2020-05-18 13:21inigo_lergaAssigned To => inigo_lerga
2020-05-18 13:21inigo_lergaOBNetwork customer => No
2020-05-18 13:21inigo_lergaRelationship addedrelated to 0041287
2020-05-18 13:21inigo_lergaStatusnew => scheduled
2020-05-18 13:57inigo_lergaNote Added: 0119987
2020-06-01 16:36hgbotCheckin
2020-06-01 16:36hgbotNote Added: 0120500
2020-06-01 16:36hgbotStatusscheduled => resolved
2020-06-01 16:36hgbotResolutionopen => fixed
2020-06-01 16:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/9259db956c854c937bcbd90039d1f545aaa25dec [^]
2020-06-01 16:38dmiguelezReview Assigned To => dmiguelez
2020-06-01 16:38dmiguelezNote Added: 0120501
2020-06-01 16:38dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0119987)
inigo_lerga   
2020-05-18 13:57   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs are executed#
(0120500)
hgbot   
2020-06-01 16:36   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 9259db956c854c937bcbd90039d1f545aaa25dec
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon May 18 13:54:20 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/9259db956c854c937bcbd90039d1f545aaa25dec [^]

fixes BUG-44085:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/utils/AWOReservationForTask.java
---
(0120501)
dmiguelez   
2020-06-01 16:38   
Code Review + Testing Ok