Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044073ModulesAdvanced Warehouse Operationspublic2020-05-15 12:052020-06-01 13:48
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0044073: Apply new HQL Style in WarehouseAlgorithmsUtils.java
DescriptionWarehouseAlgorithmsUtils.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-15 12:05inigo_lergaNew Issue
2020-05-15 12:05inigo_lergaAssigned To => inigo_lerga
2020-05-15 12:06inigo_lergaRelationship addedrelated to 0041287
2020-05-15 12:06inigo_lergaStatusnew => scheduled
2020-05-15 13:13inigo_lergaNote Added: 0119947
2020-06-01 13:47hgbotCheckin
2020-06-01 13:47hgbotNote Added: 0120489
2020-06-01 13:47hgbotStatusscheduled => resolved
2020-06-01 13:47hgbotResolutionopen => fixed
2020-06-01 13:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/8070be31fb4eeb14d0cd2715e83113508f63393a [^]
2020-06-01 13:47hgbotCheckin
2020-06-01 13:47hgbotNote Added: 0120490
2020-06-01 13:48dmiguelezReview Assigned To => dmiguelez
2020-06-01 13:48dmiguelezNote Added: 0120491
2020-06-01 13:48dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0119947)
inigo_lerga   
2020-05-15 13:13   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs are executed#
(0120489)
hgbot   
2020-06-01 13:47   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 8070be31fb4eeb14d0cd2715e83113508f63393a
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Fri May 15 13:13:45 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/8070be31fb4eeb14d0cd2715e83113508f63393a [^]

fixes BUG-44073:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/task/WarehouseAlgorithmsUtils.java
---
(0120490)
hgbot   
2020-06-01 13:47   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: a6977119d53dfff1a6e57e5c07e570a508244937
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Jun 01 13:47:00 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/a6977119d53dfff1a6e57e5c07e570a508244937 [^]

Related to ISSUE-44073. Format changes to improve redability

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/task/WarehouseAlgorithmsUtils.java
---
(0120491)
dmiguelez   
2020-06-01 13:48   
Code Review + Testing Ok