Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044067Retail ModulesWeb POSpublic2020-05-14 15:322020-06-22 10:56
Reporterranjith_qualiantech_com 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeverityminorReproducibilityrandom
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044067: Tests fails randomly due to DiscountRuleByPaymentMethod
DescriptionTests fails randomly due to DiscountRuleByPaymentMethod
AutoServicePricePercentage.java:53
I32804_GiftCardValidateReturnLine.java:53
CreateOTFAndDoVerifiedReturn.java:43
OP_Test13_AdvancedFiltersInOrderPreparation.java:211

"(2) errors in the browser log:
[2020-04-25T02:32:57+0000] [SEVERE] http://127.0.0.1/try-ret-modules-pgsql-suite1/web/js/gen/f6507b34df7f1d2900793ea8513eb253.js [^] 212:14 ""The receipt is being save during the closing: [object Object]; line: G.d.save (http://127.0.0.1/try-ret-modules-pgsql-suite1/web/js/gen/f6507b34df7f1d2900793ea8513eb253.js:51484:14 [^]) (*)""
[2020-04-25T02:32:57+0000] [SEVERE] http://127.0.0.1/try-ret-modules-pgsql-suite1/web/js/gen/f6507b34df7f1d2900793ea8513eb253.js [^] 212:14 ""The stack trace is: Error\n at G.d.save (http://127.0.0.1/try-ret-modules-pgsql-suite1/web/js/gen/f6507b34df7f1d2900793ea8513eb253.js:51483:23 [^])\n at http://127.0.0.1/try-ret-modules-pgsql-suite1/web/js/gen/f6507b34df7f1d2900793ea8513eb253.js:58765:29\n [^] at G.d.callbackExecutor (http://127.0.0.1/try-ret-modules-pgsql-suite1/web/js/gen/f6507b34df7f1d2900793ea8513eb253.js:24998:7 [^])\n at http://127.0.0.1/try-ret-modules-pgsql-suite1/web/js/gen/f6507b34df7f1d2900793ea8513eb253.js:182676:25\n [^] at G.d.callbackExecutor (http://127.0.0.1/try-ret-modules-pgsql-suite1/web/js/gen/f6507b34df7f1d2900793ea8513eb253.js:24998:7 [^])\n at http://127.0.0.1/try-ret-modules-pgsql-suite1/web/js/gen/f6507b34df7f1d2900793ea8513eb253.js:174238:27\n [^] at Object.OB.DISXPM.getDiscountRuleByPaymentMethod (http://127.0.0.1/try-ret-modules-pgsql-suite1/web/js/gen/f6507b34df7f1d2900793ea8513eb253.js:174045:7 [^]); line: G.d.save (http://127.0.0.1/try-ret-modules-pgsql-suite1/web/js/gen/f6507b34df7f1d2900793ea8513eb253.js:51487:14 [^]) (*)"""
Steps To Reproducehttps://ci.openbravo.com/job/try-ret-modules-pgsql-suite1/17607/ [^]
https://ci.openbravo.com/job/try-ret-modules-oracle-suite3/2800/ [^]
https://ci.openbravo.com/job/try-ret-modules-pgsql-suite2/10438/ [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-14 15:32ranjith_qualiantech_comNew Issue
2020-05-14 15:32ranjith_qualiantech_comAssigned To => ranjith_qualiantech_com
2020-05-14 15:32ranjith_qualiantech_comOBNetwork customer => No
2020-05-14 15:32ranjith_qualiantech_comTriggers an Emergency Pack => No
2020-05-15 09:56ranjith_qualiantech_comStatusnew => scheduled
2020-05-21 07:47hgbotCheckin
2020-05-21 07:47hgbotNote Added: 0120108
2020-05-21 07:47hgbotStatusscheduled => resolved
2020-05-21 07:47hgbotResolutionopen => fixed
2020-05-21 07:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b29b4c99e37590fbc2ff1a0653626719a4c11657 [^]
2020-05-22 12:44migueldejuanaReview Assigned To => migueldejuana
2020-05-22 12:44migueldejuanaStatusresolved => closed
2020-05-27 12:28migueldejuanaNote Added: 0120354
2020-05-27 12:28migueldejuanaStatusclosed => new
2020-05-27 12:28migueldejuanaResolutionfixed => open
2020-05-27 16:36ranjith_qualiantech_comStatusnew => scheduled
2020-05-27 16:36hgbotCheckin
2020-05-27 16:36hgbotNote Added: 0120366
2020-05-29 08:55migueldejuanaStatusscheduled => resolved
2020-05-29 08:55migueldejuanaResolutionopen => fixed
2020-06-16 13:11hgbotCheckin
2020-06-16 13:11hgbotNote Added: 0120864
2020-06-22 10:56marvintmReview Assigned Tomigueldejuana => marvintm
2020-06-22 10:56marvintmStatusresolved => closed
2020-06-22 10:56marvintmFixed in Version => RR20Q3

Notes
(0120108)
hgbot   
2020-05-21 07:47   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b29b4c99e37590fbc2ff1a0653626719a4c11657
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu May 21 11:17:05 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b29b4c99e37590fbc2ff1a0653626719a4c11657 [^]

Fixed issue-44067 : Moved addPayment ProcessController to postAddPayment hook

* For completion of AddPayment process,
  MobileProcess 'addPayment' should be finished in postAddPayment hook

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0120354)
migueldejuana   
2020-05-27 12:28   
Still happening:

https://ci.openbravo.com/job/try-ret-modules-pgsql-suite3/2990/ [^]
(0120366)
hgbot   
2020-05-27 16:36   
Repository: erp/pmods/org.openbravo.retail.discounts.bypaymentmethod
Changeset: f0f46a091d462ce688c6484b64946bc0c2dced91
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed May 27 20:06:09 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bypaymentmethod/rev/f0f46a091d462ce688c6484b64946bc0c2dced91 [^]

Related to issue 44067 : Added Callback for non synchronous function

* For hook operation, process to be completed before calling hookcallback.

---
M web/org.openbravo.retail.discounts.bypaymentmethod/js/paymentmethod-discount.js
---
(0120864)
hgbot   
2020-06-16 13:11   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d49d3402c90c52d6526aad50d6cfb1ec0b9c2aa2
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Jun 16 16:40:35 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d49d3402c90c52d6526aad50d6cfb1ec0b9c2aa2 [^]

Related to issue-44067 : Removed unwanted ProcessController in addPayment

* Refactored ProcessController by finishing it inside save operation

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---